Skip to content

Commit

Permalink
test: fix test to allow quictls fork of OpenSSL 3
Browse files Browse the repository at this point in the history
The quictls fork of OpenSSL identifies itself with a `+quic` suffix
in its version string. This was previously rejected by the version
string check as the `+` was not an allowed character.

PR-URL: nodejs#38372
Refs: nodejs@7ac6265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
richardlau authored and danbev committed Apr 26, 2021
1 parent 55745a1 commit dee3741
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-process-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if (common.hasCrypto) {
// The following also matches a development version of OpenSSL 3.x which
// can be in the format '3.0.0-alpha4-dev'. This can be handy when building
// and linking against the main development branch of OpenSSL.
/^\d+\.\d+\.\d+(-[-a-z0-9]+)?$/ :
/^\d+\.\d+\.\d+(?:[-+][a-z0-9]+)*$/ :
/^\d+\.\d+\.\d+[a-z]?(\+quic)?(-fips)?$/;
assert(versionRegex.test(process.versions.openssl));
}
Expand Down

0 comments on commit dee3741

Please sign in to comment.