Fix Dockerfile example in "Deploying" chapter #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now matches the layout of a typical project, instead of erroring out.
Comment on lines
+266
to
+267
| COPY --from=build /build/stati[c] ./static/ | ||
| COPY --from=build /build/template[s] ./templates/ |
There was a problem hiding this comment.
Are these changes functional?
There was a problem hiding this comment.
Yes and no. They aren't strictly needed and generally if the fix on the previous line is applied, it will work the same, but if the next two lines are applied and not the first, the error message can change, maybe depending on the coreutils version one uses.
I don't feel strongly about this, I thought it was a touch clearer. The first line is the important fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now matches the layout of a typical project, instead of erroring out.