Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile example in "Deploying" chapter #2898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Dockerfile example in "Deploying" chapter #2898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/guide/11-deploying.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ WORKDIR /app
COPY --from=build /build/main ./

## copy runtime assets which may or may not exist
COPY --from=build /build/Rocket.tom[l] ./static
COPY --from=build /build/stati[c] ./static
COPY --from=build /build/template[s] ./templates
COPY --from=build /build/Rocket.tom[l] ./
COPY --from=build /build/stati[c] ./static/
COPY --from=build /build/template[s] ./templates/
Comment on lines +266 to +267
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes functional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. They aren't strictly needed and generally if the fix on the previous line is applied, it will work the same, but if the next two lines are applied and not the first, the error message can change, maybe depending on the coreutils version one uses.

I don't feel strongly about this, I thought it was a touch clearer. The first line is the important fix.


## ensure the container listens globally on port 8080
ENV ROCKET_ADDRESS=0.0.0.0
Expand Down