Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roborock S6 Pure to support vacuum models. #1172

Closed
wants to merge 1 commit into from

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Nov 1, 2021

home-assistant/core#58550 (comment)

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #1172 (11ca404) into master (e1adea5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files          79       79           
  Lines        9220     9221    +1     
  Branches      761      761           
=======================================
+ Hits         7184     7185    +1     
  Misses       1852     1852           
  Partials      184      184           
Impacted Files Coverage Δ
miio/vacuum.py 60.62% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1adea5...11ca404. Read the comment docs.

@rytilahti
Copy link
Owner

All the model additions should be wait a bit until we have feature flags to signal which non-common features are supported by the given model. Also, could you merge the recent PRs into a single one @OGKevin, and give me a week to come up with a plan for the feature flags prior doing that?

@OGKevin
Copy link
Contributor Author

OGKevin commented Nov 2, 2021

Closing in favour of #1173

@OGKevin OGKevin closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants