-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more supported vacuum models #1173
Add more supported vacuum models #1173
Conversation
for referecne: home-assistant/core#58550 (comment) Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
home-assistant/core#57474 (comment) Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
home-assistant/core#58550 (comment) Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
…d-more-supported-vacuum-models
…o add-more-supported-vacuum-models
…ore-supported-vacuum-models
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 77.91% 78.31% +0.39%
==========================================
Files 79 84 +5
Lines 9220 9521 +301
Branches 761 775 +14
==========================================
+ Hits 7184 7456 +272
- Misses 1852 1879 +27
- Partials 184 186 +2
Continue to review full report at Codecov.
|
@OGKevin do you happen to have a list of features that are only available on some models? I have been looking into some potential flags. It's probably a good idea to start with something simple (so not adding all of these at once) and extend from that, but it would be really helpful to have some sort of list of different features available:
edit: https://smartrobotreviews.com/s/robot-vacuums/roborock-comparison-chart/ has some comparisons. Looks like many models support mopping, but some of the features (like the "water output control" and "electronic water tank") differ from device to device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged now for the next release so that we can leverage it inside homeassistant instead of depending on the consts.
Add supported models that have been reported by users of HA.
This PR is in favour of all the 3 small ones to add the models.