Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more supported vacuum models #1173

Merged
merged 6 commits into from
Nov 29, 2021

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Nov 2, 2021

Add supported models that have been reported by users of HA.

This PR is in favour of all the 3 small ones to add the models.

for referecne: home-assistant/core#58550 (comment)

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
home-assistant/core#57474 (comment)

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
home-assistant/core#58550 (comment)

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #1173 (cf0c558) into master (e1adea5) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   77.91%   78.31%   +0.39%     
==========================================
  Files          79       84       +5     
  Lines        9220     9521     +301     
  Branches      761      775      +14     
==========================================
+ Hits         7184     7456     +272     
- Misses       1852     1879      +27     
- Partials      184      186       +2     
Impacted Files Coverage Δ
miio/integrations/vacuum/roborock/vacuum_tui.py 0.00% <ø> (ø)
miio/__init__.py 100.00% <100.00%> (ø)
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 83.54% <100.00%> (ø)
...ions/vacuum/dreame/tests/test_dreamevacuum_miot.py 100.00% <100.00%> (ø)
miio/integrations/vacuum/mijia/__init__.py 100.00% <100.00%> (ø)
miio/integrations/vacuum/mijia/g1vacuum.py 74.14% <100.00%> (ø)
miio/integrations/vacuum/roborock/__init__.py 100.00% <100.00%> (ø)
.../integrations/vacuum/roborock/tests/test_vacuum.py 98.01% <100.00%> (ø)
miio/integrations/vacuum/roborock/vacuum.py 60.80% <100.00%> (ø)
...o/integrations/vacuum/roborock/vacuumcontainers.py 77.32% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1adea5...cf0c558. Read the comment docs.

@rytilahti
Copy link
Owner

rytilahti commented Nov 2, 2021

@OGKevin do you happen to have a list of features that are only available on some models?

I have been looking into some potential flags. It's probably a good idea to start with something simple (so not adding all of these at once) and extend from that, but it would be really helpful to have some sort of list of different features available:

  • Supports percentage based fan speeds
  • Supports timers
  • Supports DnD mode
  • Supports mopping
  • Supports mopping modes ("mop routing on s7", likely similar to viomi patterns)
  • Supports carpet cleaning/avoidance mode
  • Supports water flow controls
  • Supports automatic bin cleaning

edit: https://smartrobotreviews.com/s/robot-vacuums/roborock-comparison-chart/ has some comparisons. Looks like many models support mopping, but some of the features (like the "water output control" and "electronic water tank") differ from device to device.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged now for the next release so that we can leverage it inside homeassistant instead of depending on the consts.

@rytilahti rytilahti merged commit cb8ea87 into rytilahti:master Nov 29, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants