Add yeelink.bhf_light.v2 and yeelink.light.lamp22 support #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have these two devices but not list in specs.yaml
Kirmas
reviewed
Dec 14, 2021
Comment on lines
168
to
170
| yeelink.bhf_light.v2: | ||
| night_light: False | ||
| supports_color: False |
There was a problem hiding this comment.
Yeelight Smart Bath Heater - for my opinion this is not a Lamp. This is separate device. With other features. We must add it as separate devise like Smart Bath Heater or similar. Look to issue #702
@rytilahti What do you think?
There was a problem hiding this comment.
Yes, it's not actually a lamp, but its lighting function is actually a yeelight lamp. I use https://github.com/al-one/hass-miio-yeelink this custom_component to integrate it to hass, the heater's function works as a fan and the lighting function generate a yeelink entity. I'm not sure should it add to this list.
And after update to homeassistant 2021.12.0, I got this issue in log:
Logger: miio.integrations.yeelight.spec_helper
Source: /usr/local/lib/python3.9/site-packages/miio/integrations/yeelight/spec_helper.py:81
First occurred: 16:14:39 (1 occurrences)
Last logged: 16:14:39
Unknown model yeelink.bhf_light.v2, please open an issue and supply features for this light. Returning generic information.
There was a problem hiding this comment.
I don't see any downsides for having this added for anyone who wants to use the interface to control the light :-) The code might need to be changed to accommodate the missing color_temp key, or should it be marked just with range [0, 0]?
There was a problem hiding this comment.
Looks like it didn't pass the test, i'll change it to color_temp: [0, 0]
This comment has been minimized.
This comment has been minimized.
|
Thanks @FaintGhost 👍 |
rytilahti
changed the title
rytilahti
added a commit
that referenced
this pull request
Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models: * philips_bulb now defaults to a bulb that has color temperature setting * gateway devices do not perform an info query as that is handled by their parent Also, the list of the supported models was extended thanks to the feedback from the community! [Full Changelog](0.5.9.1...0.5.9.2) **Implemented enhancements:** - Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost)) - Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti)) - Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti)) **Fixed bugs:** - Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86)) - gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG)) - mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti)) - Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n)) **Merged pull requests:** - philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas)) - Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas)) - Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti)) - Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh)) - vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti)) - philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Merged
rytilahti
added a commit
that referenced
this pull request
Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models: * philips_bulb now defaults to a bulb that has color temperature setting * gateway devices do not perform an info query as that is handled by their parent Also, the list of the supported models was extended thanks to the feedback from the community! [Full Changelog](0.5.9.1...0.5.9.2) **Implemented enhancements:** - Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost)) - Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti)) - Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti)) **Fixed bugs:** - Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86)) - gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG)) - mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti)) - Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n)) **Merged pull requests:** - philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas)) - Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas)) - Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti)) - Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh)) - vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti)) - philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have these two devices but not list in specs.yaml.
yeelink.bhf_light.v2do not havecolor_tempfeature, I'm not sure if deleting this line is ok.