Deprecate wifi_led in favor of led #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this makes all devices with leds to have a common interface
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
=======================================
Coverage 82.37% 82.38%
=======================================
Files 109 109
Lines 11832 11850 +18
Branches 1397 1399 +2
=======================================
+ Hits 9747 9763 +16
Misses 1877 1877
- Partials 208 210 +2
Continue to review full report at Codecov.
|
rytilahti
added a commit
that referenced
this pull request
Mar 7, 2022
This release fixes zhimi.fan.za5 support and makes all integrations introspectable for their supported models. For developers, there is now a network trace parser (in devtools/parse_pcap.py) that prints the decrypted the traffic for given tokens. The following previously deprecated classes in favor of model-based discovery, if you were using these classes directly you need to adjust your code: * AirFreshVA4 - use AirFresh * AirHumidifierCA1, AirHumidifierCB1, AirHumidifierCB2 - use AirHumidifier * AirDogX5, AirDogX7SM - use AirDogX3 * AirPurifierMB4 - use AirPurifierMiot * Plug, PlugV1, PlugV3 - use ChuangmiPlug * FanP9, FanP10, FanP11 - use FanMiot * DreameVacuumMiot - use DreameVacuum * Vacuum - use RoborockVacuum [Full Changelog](0.5.10...0.5.11) **Breaking changes:** - Remove deprecated integration classes [\#1343](#1343) (@rytilahti) **Implemented enhancements:** - Add PCAP file parser for protocol analysis [\#1331](#1331) (@rytilahti) **Fixed bugs:** - Fix bug for zhimi.fan.za5 resulting in user ack timeout [\#1348](#1348) (@saxel) **Deprecated:** - Deprecate wifi\_led in favor of led [\#1342](#1342) (@rytilahti) **Merged pull requests:** - Make sure miotdevice implementations define supported models [\#1345](#1345) (@rytilahti) - Add Viomi V2 \(viomi.vacuum.v6\) as supported [\#1340](#1340) (@rytilahti) - Mark Roborock S7 MaxV \(roborock.vacuum.a27\) as supported [\#1337](#1337) (@rytilahti) - Add pyupgrade to CI runs [\#1329](#1329) (@rytilahti)
Merged
rytilahti
added a commit
that referenced
this pull request
Mar 7, 2022
This release fixes zhimi.fan.za5 support and makes all integrations introspectable for their supported models. For developers, there is now a network trace parser (in devtools/parse_pcap.py) that prints the decrypted the traffic for given tokens. The following previously deprecated classes in favor of model-based discovery, if you were using these classes directly you need to adjust your code: * AirFreshVA4 - use AirFresh * AirHumidifierCA1, AirHumidifierCB1, AirHumidifierCB2 - use AirHumidifier * AirDogX5, AirDogX7SM - use AirDogX3 * AirPurifierMB4 - use AirPurifierMiot * Plug, PlugV1, PlugV3 - use ChuangmiPlug * FanP9, FanP10, FanP11 - use FanMiot * DreameVacuumMiot - use DreameVacuum * Vacuum - use RoborockVacuum [Full Changelog](0.5.10...0.5.11) **Breaking changes:** - Remove deprecated integration classes [\#1343](#1343) (@rytilahti) **Implemented enhancements:** - Add PCAP file parser for protocol analysis [\#1331](#1331) (@rytilahti) **Fixed bugs:** - Fix bug for zhimi.fan.za5 resulting in user ack timeout [\#1348](#1348) (@saxel) **Deprecated:** - Deprecate wifi\_led in favor of led [\#1342](#1342) (@rytilahti) **Merged pull requests:** - Make sure miotdevice implementations define supported models [\#1345](#1345) (@rytilahti) - Add Viomi V2 \(viomi.vacuum.v6\) as supported [\#1340](#1340) (@rytilahti) - Mark Roborock S7 MaxV \(roborock.vacuum.a27\) as supported [\#1337](#1337) (@rytilahti) - Add pyupgrade to CI runs [\#1329](#1329) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this makes all devices with leds to have a common interface. chuangmi_plug and powerstrip are affected:
set_led(bool)instead ofset_wifi_led(bool)led() -> boolinstead ofwifi_led() -> boolfor status