Skip to content

Commit

Permalink
Revert "add about section for template 1 and 8 (#106)"
Browse files Browse the repository at this point in the history
This reverts commit a8b8beb.
  • Loading branch information
saadq committed Dec 25, 2019
1 parent f8c813f commit 8920969
Show file tree
Hide file tree
Showing 11 changed files with 5 additions and 97 deletions.
5 changes: 2 additions & 3 deletions app/client/src/app/pages/Error404.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const ComicImage = styled.img`

const ComicCite = styled.cite`
margin: 1.5em 0;
font-size: 0.85em;
font-size: .85em;
font-style: normal;
`

Expand All @@ -66,8 +66,7 @@ const ButtonContainer = styled.div`
`

const Button = PrimaryButton.extend`
font-family: -apple-system, system-ui, BlinkMacSystemFont, 'Segoe UI', Roboto,
'Helvetica Neue', Arial, sans-serif;
font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;
display: flex;
justify-content: center;
align-items: center;
Expand Down
12 changes: 1 addition & 11 deletions app/client/src/common/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,4 @@ import ScrollToTop from './ScrollToTop'
import Loader, { Bars } from './Loader'
import Logo from './Logo'

export {
Button,
PrimaryButton,
RoundButton,
Divider,
Icon,
ScrollToTop,
Loader,
Logo,
Bars
}
export { Button, PrimaryButton, RoundButton, Divider, Icon, ScrollToTop, Loader, Logo, Bars }
1 change: 0 additions & 1 deletion app/client/src/common/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
type Section =
| 'templates'
| 'profile'
| 'about'
| 'education'
| 'work'
| 'skills'
Expand Down
2 changes: 0 additions & 2 deletions app/client/src/features/form/components/Form.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import styled from 'styled-components'
import {
Templates,
Profile,
About,
Education,
Work,
Skills,
Expand Down Expand Up @@ -104,7 +103,6 @@ class Form extends Component<Props> {
/>
<Route exact path="/generator/templates" component={Templates} />
<Route exact path="/generator/profile" component={Profile} />
<Route exact path="/generator/about" component={About} />
<Route exact path="/generator/education" component={Education} />
<Route exact path="/generator/work" component={Work} />
<Route exact path="/generator/skills" component={Skills} />
Expand Down
2 changes: 0 additions & 2 deletions app/client/src/features/form/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import Form from './Form'
import Templates from './sections/Templates'
import Profile from './sections/Profile'
import About from './sections/About'
import Education from './sections/Education'
import Work from './sections/Work'
import Skills from './sections/Skills'
Expand All @@ -20,7 +19,6 @@ import Award from './fragments/Award'
export {
Templates,
Profile,
About,
Education,
Work,
Skills,
Expand Down
28 changes: 0 additions & 28 deletions app/client/src/features/form/components/sections/About.js

This file was deleted.

10 changes: 2 additions & 8 deletions app/client/src/features/progress/components/SortableList.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,7 @@ const Item = styled.div`
const SortableItem = SortableElement(({ value }) => {
return (
<Item>
<DragHandle
disabled={
value === 'templates' || value === 'profile' || value === 'about'
}
/>
<DragHandle disabled={value === 'templates' || value === 'profile'} />
<NavItem to={`/generator/${value}`}>{titleCase(value)}</NavItem>
</Item>
)
Expand All @@ -95,9 +91,7 @@ const SortableList = SortableContainer(({ items }) => {
<List>
{items.map((value, index) => (
<SortableItem
disabled={
value === 'templates' || value === 'profile' || value === 'about'
}
disabled={value === 'templates' || value === 'profile'}
key={`item-${index}`}
index={index}
value={value}
Expand Down
1 change: 0 additions & 1 deletion app/client/src/features/progress/reducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const initialState = {
sections: [
'templates',
'profile',
'about',
'education',
'work',
'skills',
Expand Down
18 changes: 0 additions & 18 deletions app/server/src/generator/templates/template1/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,6 @@ const generator: Template1Generator = {
`
},

aboutSection(basics, heading) {
if (!basics || !basics.summary) {
return ''
}

return source`
%==== About ====%
\\header{${heading || 'About'}}
${basics.summary}
\\vspace{2mm}
`
},

educationSection(education, heading) {
if (!education) {
return ''
Expand Down Expand Up @@ -367,11 +354,6 @@ function template1(values: SanitizedValues) {
case 'profile':
return generator.profileSection(values.basics)
case 'about':
return generator.aboutSection
? generator.aboutSection(values.basics, headings.about)
: ''
case 'education':
return generator.educationSection(
values.education,
Expand Down
19 changes: 0 additions & 19 deletions app/server/src/generator/templates/template8/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,6 @@ const generator: Template8Generator = {
`
},

aboutSection(basics, heading) {
if (!basics || !basics.summary) {
return ''
}

return source`
\\begin{cvsection}{${heading || 'About'}}
\\begin{cvsubsection}{}{}{}
${basics.summary}
\\end{cvsubsection}
\\end{cvsection}
`
},

educationSection(education, heading) {
if (!education) {
return ''
Expand Down Expand Up @@ -299,11 +285,6 @@ function template8(values: SanitizedValues) {
${values.sections
.map(section => {
switch (section) {
case 'about':
return generator.aboutSection
? generator.aboutSection(values.basics, headings.about)
: ''
case 'education':
return generator.educationSection(
values.education,
Expand Down
4 changes: 0 additions & 4 deletions app/server/src/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
type Section =
| 'templates'
| 'profile'
| 'about'
| 'education'
| 'work'
| 'skills'
| 'projects'
| 'awards'

type Headings = {
about?: string,
work?: string,
education?: string,
skills?: string,
Expand All @@ -23,7 +21,6 @@ type Headings = {

type Basics = {
name?: string,
summary?: string,
email?: string,
phone?: string,
website?: string,
Expand Down Expand Up @@ -85,7 +82,6 @@ type SanitizedValues = {

type Generator = {
profileSection: (basics?: Basics) => string,
aboutSection?: (basics?: Basics, heading?: string) => string,
educationSection: (education?: Array<School>, heading?: string) => string,
workSection: (work?: Array<Job>, heading?: string) => string,
skillsSection: (skills?: Array<Skill>, heading?: string) => string,
Expand Down

0 comments on commit 8920969

Please sign in to comment.