-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add about section for template 1 and 8 #106
Conversation
@ducaale Awesome work, thanks so much for the PR! I'll be able to take a look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautifully done PR overall :D
The only things that need fixing are some minor Flow type issues. You can run npm run flow
in the command line to run Flow's typechecker. While in the client
folder, running npm run flow
will check for type issues on the client-side files, and running npm run flow
in the server
folder will do the same for the server-side code (Note: Running flow
for the first time can take a minute or two, but any subsequent run will be fast). There's also IDE extensions for Flow on most editors so you don't have to run it on the command line every time.
The comments I left on the CR should account for any/all type errors, but it's good to know.
Thanks so much @ducaale, great work! I won't be able to deploy this change until About section support is there for every template, but it should be easy to add those sections for the rest of the templates since you already setup everything else. I can hopefully get to adding the About section for the rest of the templates next week. Thanks again @ducaale :) |
This pull request adds
About section
which is used in most JSON Resume Examples