Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add about section for template 1 and 8 #106

Merged
merged 5 commits into from
Sep 22, 2019
Merged

add about section for template 1 and 8 #106

merged 5 commits into from
Sep 22, 2019

Conversation

ducaale
Copy link
Collaborator

@ducaale ducaale commented Sep 19, 2019

This pull request adds About section which is used in most JSON Resume Examples

@saadq
Copy link
Owner

saadq commented Sep 21, 2019

@ducaale Awesome work, thanks so much for the PR! I'll be able to take a look at this tomorrow.

Copy link
Owner

@saadq saadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully done PR overall :D

The only things that need fixing are some minor Flow type issues. You can run npm run flow in the command line to run Flow's typechecker. While in the client folder, running npm run flow will check for type issues on the client-side files, and running npm run flow in the server folder will do the same for the server-side code (Note: Running flow for the first time can take a minute or two, but any subsequent run will be fast). There's also IDE extensions for Flow on most editors so you don't have to run it on the command line every time.

The comments I left on the CR should account for any/all type errors, but it's good to know.

app/server/src/types.js Show resolved Hide resolved
app/server/src/types.js Outdated Show resolved Hide resolved
app/server/src/generator/templates/template8/index.js Outdated Show resolved Hide resolved
app/server/src/generator/templates/template1/index.js Outdated Show resolved Hide resolved
app/client/src/features/progress/reducer.js Show resolved Hide resolved
@ducaale ducaale requested a review from saadq September 22, 2019 11:09
@saadq saadq merged commit a8b8beb into saadq:master Sep 22, 2019
@saadq
Copy link
Owner

saadq commented Sep 22, 2019

Thanks so much @ducaale, great work! I won't be able to deploy this change until About section support is there for every template, but it should be easy to add those sections for the rest of the templates since you already setup everything else.

I can hopefully get to adding the About section for the rest of the templates next week. Thanks again @ducaale :)

saadq added a commit that referenced this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants