SaaSquatch Docs Update #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekSiemens
reviewed
Mar 2, 2022
|
The package locks that you added @zachserviss need to be deleted and removed from this PR |
|
Title and description need to be updated for the changes made in this PR |
|
@zachserviss That should go into the section at the top of the PR |
DerekSiemens
reviewed
Mar 2, 2022
DerekSiemens
reviewed
Mar 4, 2022
DerekSiemens
reviewed
Mar 4, 2022
DerekSiemens
reviewed
Mar 4, 2022
DerekSiemens
reviewed
Mar 9, 2022
DerekSiemens
reviewed
Mar 9, 2022
DerekSiemens
reviewed
Mar 9, 2022
DerekSiemens
reviewed
Mar 9, 2022
DerekSiemens
reviewed
Mar 9, 2022
DerekSiemens
reviewed
Mar 9, 2022
added 2 commits
March 10, 2022 15:13
src/components/TocFrame.tsx
Outdated
| fields?: { seoDescription?: string }; | ||
| fields?: { | ||
| seoDescription?: string, | ||
| ogFeaturedImage?: { |
There was a problem hiding this comment.
Flagging type fix needed, you mentioned this was actually an array of objects
src/components/Meta.tsx
Outdated
| } | ||
|
|
||
| let ogImageURL:string; | ||
| if(props?.fields?.ogFeaturedImage != null && Object.keys(props?.fields?.ogFeaturedImage).length >0){ |
There was a problem hiding this comment.
Suggested change
| if(props?.fields?.ogFeaturedImage != null && Object.keys(props?.fields?.ogFeaturedImage).length >0){ | |
| if(props?.fields?.ogFeaturedImage != null && props?.fields?.ogFeaturedImage?.length > 0){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
-Updated
Meta.tsx-Fix 404 errors
-Edit
package-lock.jsonto run locallyTypes of changes