Issues list clean up #156
Issues list clean up #156
Conversation
|
This PR is branched off of #155. It should not include changes from the other PR, if it relies on those changes then maybe the two PR's should be merged together |
public/mobile/android/docs/com/wholepunk/saasquatch/package-summary.html
Outdated
Show resolved
Hide resolved
| @@ -12,6 +12,7 @@ import TOC from "./TOC"; | |||
| */ | |||
| export type Entry = { | |||
| title: string; | |||
| robots?: string; | |||
There was a problem hiding this comment.
I wonder if we can change the usage of just the plain robots in the docs within the code so we don't need two types
| } | ||
|
|
||
| let ogImageURL:string; | ||
| if(props?.fields?.ogFeaturedImage != null && Object.keys(props?.fields?.ogFeaturedImage).length > 0){ |
There was a problem hiding this comment.
There must be a cleaner way to do this
✅ Deploy Preview for saasquatch-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| <meta property="og:image" content={ogImageURL || ogImage} /> | ||
| <meta name="twitter:image" content={ogImageURL || ogImage} /> | ||
|
|
||
| <meta name="robots" content={props.fields?.robotsTag || props?.robots} /> |
There was a problem hiding this comment.
Noting that the contentful default here is "FOLLOW", lets make sure that is handled appropriately
There was a problem hiding this comment.
Also need to make sure this is handled well for the content within the code that does not have any robots information
| @@ -1,6 +1,7 @@ | |||
| import React from "react"; | |||
| import marked from "marked"; | |||
|
|
|||
| // import ogImage from "../assets/images/opengraph-center-crop-helpcenter.png"; | |||
| const ogImage = require("../assets/images/opengraph-center-crop-helpcenter.png"); | |||
There was a problem hiding this comment.
Lets fix this before sending it out
Description of the change
Removing duplicate issues (RS17/27) and redirecting traffic to RS20
Types of changes