Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: #95219 - TypoScriptFrontendController->ATagParams #2670

Closed
sabbelasichon opened this issue Oct 6, 2021 · 0 comments · Fixed by #2725
Closed

Deprecation: #95219 - TypoScriptFrontendController->ATagParams #2670

sabbelasichon opened this issue Oct 6, 2021 · 0 comments · Fixed by #2725

Comments

@sabbelasichon
Copy link
Owner

Deprecation: #95219 - TypoScriptFrontendController->ATagParams

https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/11.5/Deprecation-95219-TypoScriptFrontendController-ATagParams.html
.. include:: ../../Includes.txt

==============================================================
Deprecation: #95219 - TypoScriptFrontendController->ATagParams

See :issue:95219

Description

The public property :php:TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->ATagParams
has been marked as deprecated.

It was used in the past as a copy of the value
:php:TypoScriptFrontendController->config[config][ATagParams],
which should be used instead.

There is no need to use such a (less prominent) configuration option in a
separate public property, as it needs to be kept in sync with the
actual configuration option.

The second argument of the related method
:php:TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getATagParams()
called :php:$addGlobal is also marked as deprecated, and will have no effect
anymore in TYPO3 v12.

Impact

Accessing, setting or writing this property will trigger a PHP :php:E_USER_DEPRECATED error.

Calling :php:ContentObjectRenderer->getATagParams()
with a second argument set to false will trigger a PHP :php:E_USER_DEPRECATED error
as well.

Affected Installations

TYPO3 installations with third-party-extensions accessing, or
writing this property directly within PHP, or calling :php:getATagParams()
directly, which is highly unlikely.

Migration

All calls of :php:$GLOBALS['TSFE']->ATagParams can be replaced
with :php:$GLOBALS['TSFE']->config['config']['ATagParams'] ?? ''.

.. index:: Frontend, PHP-API, TypoScript, FullyScanned, ext:frontend

@sabbelasichon sabbelasichon self-assigned this Oct 7, 2021
@sabbelasichon sabbelasichon removed their assignment Oct 25, 2021
@helsner helsner self-assigned this Nov 3, 2021
helsner added a commit that referenced this issue Nov 3, 2021
helsner added a commit that referenced this issue Nov 4, 2021
* [FEAT] Replace TSFE->ATagParams calls

Relates: #2670
helsner added a commit that referenced this issue Nov 4, 2021
helsner added a commit that referenced this issue Nov 4, 2021
helsner added a commit that referenced this issue Nov 4, 2021
helsner added a commit that referenced this issue Nov 4, 2021
sabbelasichon pushed a commit that referenced this issue Nov 7, 2021
* feat: handle deprecated arguments for ContentObjectRenderer->getAtagParams()

Resolves: #2670

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants