[FEAT] Replace TSFE->ATagParams calls #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was hell itself IMHO.. the array and property switching was pretty hard and i don't even know how i got it. BE AWARE: this does only solve one part of the RST-file, as the method call is not changed - should i do that as well in another rule? (would do so, but ask before wasting time) |
|
@helsner I would create another rule for the second part of the RST-File. Really well solved. Nothing to add. |
|
OK will do so tomorrow |
|
I would merge myself this time if everything is clear hihi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #2670