Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep erasing after releasing stylus button #785

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

ZebraVogel94349
Copy link
Contributor

Previously, when erasing using the stylus button, the eraser got disabled after releasing the button. This commit makes the tool switch after lifting the stylus from the screen, so you don't need to press the button the whole time you want to erase something, similar to other handwritten note apps.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #785 (b849958) into main (80ce68d) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   43.64%   43.64%   -0.01%     
==========================================
  Files          91       91              
  Lines        6399     6400       +1     
==========================================
  Hits         2793     2793              
- Misses       3606     3607       +1     
Impacted Files Coverage Δ
lib/pages/editor/editor.dart 35.53% <16.66%> (-0.05%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants