Move precompiles to precompiles directory #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
changed the title
smol-ninja
changed the title
smol-ninja
changed the title
andreivladbrg
requested changes
Mar 10, 2024
There was a problem hiding this comment.
Let's ignore the precompiles dir in the .codecove.yaml file because coverage has significantly decreased even though the file is tested.
https://github.com/sablier-labs/v2-core/blob/refactor/precompiles-directory/codecov.yml
Let's first merge #839 and then rebase from refactor/remove-protocol-fee to remove comptroller precompiles.
smol-ninja
force-pushed
the
refactor/precompiles-directory
branch
from
29106dd
to
767ee54
Compare
|
Andrei, I have included your suggestions. lmk if it looks good now. |
smol-ninja
force-pushed
the
refactor/precompiles-directory
branch
from
767ee54
to
f3ca263
Compare
andreivladbrg
approved these changes
Mar 11, 2024
andreivladbrg
pushed a commit
that referenced
this pull request
Jul 3, 2024
* refactor: move precompiles to precompiles directory * chore: ignore precompiles directory in codecov
andreivladbrg
pushed a commit
that referenced
this pull request
Jul 3, 2024
* refactor: move precompiles to precompiles directory * chore: ignore precompiles directory in codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #789.