Cannot add custom properties to a propFind for allprops

[ghost]

Encountered when converting the SambaDAV plugin to use the SabreDAV-2.0.4 propFind and propPatch events. SabreDAV has a fixed list of properties that it will return for an "allprops" request. Fair enough. But if we add a propFind plugin that calls 'set' for a nonstandard property x, I expect property x to be hard added to the response. Instead, SabreDAV decides that property x is not in the pre-approved list, and silently drops it.

Background: in SambaDAV we always add the nonstandard {DAV:}ishidden, {DAV:}isreadonly and Win32 flag properties during a propfind, to support mounting as a Windows Network Share. I expected this (demo) code to set the property:

class MSPropertiesPlugin extends DAV\ServerPlugin
{
    public function initialize (DAV\Server $server)
    {
        $server->on('propFind', [ $this, 'propFind' ]);
    }
    public function propFind (DAV\PropFind $propFind, DAV\INode $node)
    {
        // Hide all the things!
        $propFind->set('{DAV:}ishidden', '1');
    }
}

Instead the property is ignored (unless we add it to SabreDAV's "allprops" list by hand).

[ghost]

NB, see also Issue #352. The afterGetProperties workaround no longer works in 2.0+.

[evert]

Treating this as a regression. i agree that there should be a way to do this.

[ghost]

Fixed in SabreDAV 2.1.x.