-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix propfind type of subnodes with depth >= 1 #1344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
=========================================
Coverage 97.31% 97.31%
Complexity 2806 2806
=========================================
Files 174 174
Lines 7975 7975
=========================================
Hits 7761 7761
Misses 214 214
Continue to review full report at Codecov.
|
I added a test case and we can see that it fails on master:
|
Hey @n-peugnet 👋 please rebase your branch to have a recent CI run. |
21dc3a6
to
78fb937
Compare
Done @kesselb |
@phil-davis, could you maybe approve this PR to run the GitHub workflow ? I have run the tests locally and everything is working fine. |
When custom properties are manually added in a plugin with the `propFind` event like in this example: sabre-io#482 and depth >= 1, the subnodes' propfind's type was incorrectly deducted. This resulted in custom properties only added to the first node and not on the subnodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I was looking, I refactored some identical preg_replace "magic" in the test code so that it is in a separate function.
With properties manually added in a plugin using the
propFind
event like in this example: #482 and with depth >= 1, the subnodes' propfind's type was incorrectly deduced.This resulted in custom properties only being added to the first node and not on the subnodes.