-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other matrix data type classes. #6
Comments
To make
I would prefer, second way because (in my opinion) that would be better for performance. But first way (in my opinion) would be more graceful. What do you think about it? Do you have other solutions or ideas? |
Maybe instead, modify Matrix to copy in and out of other implementations' instances? |
Oh! It seems I misunderstood the ticket's aim! If the aim is extend interface, your solution will enough. I thought, that you want to try solve assignment problem on different |
I was aiming mainly to make it easier to use this code from within existing code. I don't think it would hurt to have the Munkres class as a template, additionally. |
When I see changes which was made according to this issue, I'm not satisfied. There are a lot of classes of matrices: Qt, opencv, Eigen, etc... So it's impossible implement adaptors for all of them. It's require more generic approach. Also existed adapters pollute code. |
Test: $ mkdir build $ cd build $ cmake -DMUNKRESCPP_DEVEL_MODE=ON .. $ make cppcheck Issue: saebyn#6. Signed-off-by: Gluttton <gluttton@ukr.net>
Support other matrix data type classes from other libs (boost)?
UPD
Implemented:
std::array
(C++11);boost::numeric::ublas::matrix
;std::vector <std::vector <double> >
.The text was updated successfully, but these errors were encountered: