Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other matrix data type classes. #6

Open
Gluttton opened this issue Nov 29, 2013 · 5 comments
Open

Support other matrix data type classes. #6

Gluttton opened this issue Nov 29, 2013 · 5 comments

Comments

@Gluttton
Copy link
Contributor

Support other matrix data type classes from other libs (boost)?

UPD
Implemented:

  • std::array (C++11);
  • raw (C-style) array;
  • boost::numeric::ublas::matrix;
  • std::vector <std::vector <double> >.
@Gluttton
Copy link
Contributor Author

Gluttton commented Jan 8, 2014

To make Matrix data type generalized, I see two ways:

  • first: involve abstract data type with pure methods (which will describe interface);
  • second: Munkres class should become template which will be parameterized by specific Matrix data type.

I would prefer, second way because (in my opinion) that would be better for performance. But first way (in my opinion) would be more graceful.

What do you think about it? Do you have other solutions or ideas?

@saebyn
Copy link
Owner

saebyn commented Jan 9, 2014

Maybe instead, modify Matrix to copy in and out of other implementations' instances?

@Gluttton
Copy link
Contributor Author

Gluttton commented Jan 9, 2014

Oh! It seems I misunderstood the ticket's aim! If the aim is extend interface, your solution will enough.

I thought, that you want to try solve assignment problem on different Matrix types (may be to research performance issues)!

@saebyn
Copy link
Owner

saebyn commented Jan 10, 2014

I was aiming mainly to make it easier to use this code from within existing code. I don't think it would hurt to have the Munkres class as a template, additionally.

@Gluttton
Copy link
Contributor Author

Gluttton commented Apr 3, 2016

When I see changes which was made according to this issue, I'm not satisfied. There are a lot of classes of matrices: Qt, opencv, Eigen, etc... So it's impossible implement adaptors for all of them. It's require more generic approach. Also existed adapters pollute code.

Gluttton added a commit to Gluttton/munkres-cpp that referenced this issue Sep 5, 2020
Test: $ mkdir build
      $ cd build
      $ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
      $ make cppcheck
Issue: saebyn#6.
Signed-off-by: Gluttton <gluttton@ukr.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants