Add IStakingApi
#1823
Merged
Add IStakingApi
#1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10389904110Details
💛 - Coveralls |
hectorgomezv
approved these changes
Aug 19, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Wdds the new `IStakingApi` datasource with Kiln-based implementation and relative manager: - Add `IStakingApi` and relative `IStakingApiManager` instantiating on call and clearing on `CHAIN_UPDATE` event: - Add `KilnStakingApi` implementation of `IStakingApi` - Add respective schemas, with inferred types, builders and tests: - `Deployment` - `NetworkStats` - `DedicatedStakingStats` - `PooledStakingStats` - `DefiVaultStats` - Add `IStakingRepository` which calls the above API and parses against the respective schemas - Add appropriate test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the new
IStakingApidatasource with Kiln-based implementation and relative manager:getDeployments- returns deployments of the relative contracts for staking/vaultsgetNetworkStats- returns overall ETH stats, e.g. entry/exit/withdrawal timesgetDedicatedStakingStats- returns native staking stats, e.g. APYgetPooledStakingStats- returns pooled staking stats, e.g. GRRgetDefiVaultStats- returns vault stats, e.g. GRRNote: these methods facilitate confirmation view integration. For transaction decoding, we will likely need add others for fetching historical transactions.
Changes
IStakingApiand relativeIStakingApiManagerinstantiating on call and clearing onCHAIN_UPDATEevent:KilnStakingApiimplementation ofIStakingApiDeploymentNetworkStatsDedicatedStakingStatsPooledStakingStatsDefiVaultStatsIStakingRepositorywhich calls the above API and parses against the respective schemas