Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint caused by staking API #1832

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix lint caused by staking API #1832

merged 1 commit into from
Aug 20, 2024

Conversation

iamacook
Copy link
Member

Summary

The staking API (#1823) PR was created (and worked on) before updating ESLint (#1820). It therefore had some "new" errors meaning it broke the CI.

This fixes the above errors.

Changes

  • Assert the path in PooledStakingStatsSchema tests
  • Ignore the empty object in the IStakingManager interface

@iamacook iamacook self-assigned this Aug 20, 2024
@iamacook iamacook requested a review from a team as a code owner August 20, 2024 06:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10466685387

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.756%

Totals Coverage Status
Change from base Build 10456371873: 0.0%
Covered Lines: 4626
Relevant Lines: 8001

💛 - Coveralls

@iamacook iamacook merged commit e6a77b2 into main Aug 20, 2024
16 checks passed
@iamacook iamacook deleted the fix-lint branch August 20, 2024 08:24
DenSmolonski pushed a commit to Zilliqa/safe-client-gateway that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants