-
-
Notifications
You must be signed in to change notification settings - Fork 481
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gh-37605: Ensure returned degree of multivariate polynomial is type `…
…Integer` for `MPolynomialRing_libsingular` class Previously the degree of multivariate polynomials was returned as a python `int` instead of a SageMath `Integer` resulting in ugly `ZZ(f.degree())` calls in various places. This PR only focuses on the case of `MPolynomialRing_libsingular` to keep the noise of the PR as low as possible. **Future work**: This same issue is in `MPolynomial_polydict`, I am happy to also do the work here, or make a new PR -- really I don't like sage returning a `int` when we dont have to. **Edit** This follow up work has been done in PR: #37611 URL: #37605 Reported by: Giacomo Pope Reviewer(s): Matthias Köppe
- Loading branch information
Showing
1 changed file
with
37 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters