Ensure returned degree of multivariate polynomial is type Integer for MPolynomialRing_libsingular class
#37605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiacomoPope
changed the title
Integer for MPolynomialRing_libsingular class
|
Documentation preview for this PR (built with commit 49c34c4; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 30, 2024
…e for `MPolynomial_polydict` class
This is a follow up PR to sagemath#37605
which ensures that `degree()` and `total_degree()` return a sage
`Integer` type instead of a python `int` for the `MPolynomial_polydict`
class.
However, `f.degrees()` returns something of type
`sage.rings.polynomial.polydict.ETuple` which has elements as `int`. I
am loathed to change this to return `Integer` in case of performance
regression, so the following status of `MPolynomial_polydict` is the
following:
```py
sage: R.<x, y> = PolynomialRing(QQbar)
sage: f = 1 + x + y^2
sage: type(f.degree())
<class 'sage.rings.integer.Integer'>
sage: type(f.degree(x))
<class 'sage.rings.integer.Integer'>
sage: type(f.degree(y))
<class 'sage.rings.integer.Integer'>
sage: type(f.total_degree())
<class 'sage.rings.integer.Integer'>
sage: type(f.degrees())
<class 'sage.rings.polynomial.polydict.ETuple'>
sage: type(f.degrees()[0])
<class 'int'>
```
I would like advice on how to proceed with the `degrees()` function. Is
leaving it in it's current state OK?
Fixes sagemath#37603
URL: sagemath#37611
Reported by: Giacomo Pope
Reviewer(s): Giacomo Pope, grhkm21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the degree of multivariate polynomials was returned as a python
intinstead of a SageMathIntegerresulting in uglyZZ(f.degree())calls in various places.This PR only focuses on the case of
MPolynomialRing_libsingularto keep the noise of the PR as low as possible.Future work: This same issue is in
MPolynomial_polydict, I am happy to also do the work here, or make a new PR -- really I don't like sage returning aintwhen we dont have to.Edit
This follow up work has been done in PR: #37611