Skip to content

Commit

Permalink
Trac #34665: openssl spkg-configure.m4: Also require openssl if curl …
Browse files Browse the repository at this point in the history
…needs to be built

Seen in `opensuse-15.3-gcc_11-python3.9`:
https://github.com/mkoeppe/sage/actions/runs/3251926884/jobs/5344443553
{{{
  [curl-7.84.0]   checking for openssl options with pkg-config... no
  [curl-7.84.0]   checking for HMAC_Update in -lcrypto... no
  [curl-7.84.0]   checking for HMAC_Init_ex in -lcrypto... no
  [curl-7.84.0]   checking OpenSSL linking with -ldl... no
  [curl-7.84.0]   checking OpenSSL linking with -ldl and -lpthread... no
  [curl-7.84.0]   configure: OPT_OPENSSL: yes
  [curl-7.84.0]   configure: OPENSSL_ENABLED:
  [curl-7.84.0]   configure: error: --with-openssl was given but OpenSSL
could not be detected
  [curl-7.84.0]   ******************************************************
**************************
}}}

URL: https://trac.sagemath.org/34665
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik
  • Loading branch information
Release Manager committed Oct 31, 2022
2 parents 487f2f9 + b39ffd2 commit b508288
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions build/pkgs/openssl/spkg-configure.m4
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ On Cygwin, openssl must be installed as a system package. This is an error."])
])
], [dnl REQUIRED-CHECK
AC_REQUIRE([SAGE_SPKG_CONFIGURE_PYTHON3])
dnl openssl is a dependency only of python3; so if we use system python3,
AC_REQUIRE([SAGE_SPKG_CONFIGURE_CURL])
dnl openssl is a dependency only of python3 and curl; so if we use system python3 and curl,
dnl we do not require it. (In particular, we do not need a specific version.)
AS_IF([test x$sage_spkg_install_python3 = xno], [
AS_IF([test x$sage_spkg_install_python3 = xno -a x$sage_spkg_install_curl = xno], [
sage_require_openssl=no
])
])

0 comments on commit b508288

Please sign in to comment.