Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl spkg-configure.m4: Also require openssl if curl needs to be built #34665

Closed
mkoeppe opened this issue Oct 15, 2022 · 12 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 15, 2022

Seen in opensuse-15.3-gcc_11-python3.9:
https://github.com/mkoeppe/sage/actions/runs/3251926884/jobs/5344443553

  [curl-7.84.0]   checking for openssl options with pkg-config... no
  [curl-7.84.0]   checking for HMAC_Update in -lcrypto... no
  [curl-7.84.0]   checking for HMAC_Init_ex in -lcrypto... no
  [curl-7.84.0]   checking OpenSSL linking with -ldl... no
  [curl-7.84.0]   checking OpenSSL linking with -ldl and -lpthread... no
  [curl-7.84.0]   configure: OPT_OPENSSL: yes
  [curl-7.84.0]   configure: OPENSSL_ENABLED: 
  [curl-7.84.0]   configure: error: --with-openssl was given but OpenSSL could not be detected
  [curl-7.84.0]   ********************************************************************************

Depends on #32182

CC: @sagetrac-tmonteil @dimpase @orlitzky

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: b39ffd2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34665

@mkoeppe mkoeppe added this to the sage-9.8 milestone Oct 15, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

comment:2

Tested successfully using tox -e docker-opensuse-15.3-gcc_11-python3.9-minimal -- curl


New commits:

b39ffd2build/pkgs/openssl/spkg-configure.m4: Also require openssl if curl needs to be built

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

Commit: b39ffd2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

Dependencies: #32182

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2022

comment:6

Let's get this in please

@dimpase
Copy link
Member

dimpase commented Oct 23, 2022

comment:7

Can we refactor this using SAGE_SPKG_DEPCHECK ?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2022

comment:8

No, that's an unrelated mechanism.

@dimpase
Copy link
Member

dimpase commented Oct 25, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Oct 25, 2022

comment:9

ok

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2022

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

@vbraun vbraun closed this as completed in b508288 Nov 7, 2022
kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants