Skip to content

Commit

Permalink
gh-36085: some details in coxeter groups
Browse files Browse the repository at this point in the history
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

this is making a few little changes in the file for the category of
Coxeter groups, also fixing a typo

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #36085
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
  • Loading branch information
Release Manager committed Aug 26, 2023
2 parents 45f69ff + d5495ae commit f6af55c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
14 changes: 5 additions & 9 deletions src/sage/categories/coxeter_groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,9 +518,10 @@ def succ(u):

from sage.categories.finite_coxeter_groups import FiniteCoxeterGroups
default_category = FiniteEnumeratedSets() if self in FiniteCoxeterGroups() else EnumeratedSets()
cat = default_category.or_subcategory(category)
return RecursivelyEnumeratedSet_forest((self.one(),), succ,
algorithm='breadth',
category=default_category.or_subcategory(category))
algorithm='breadth',
category=cat)

@cached_method
def coxeter_element(self):
Expand Down Expand Up @@ -1239,10 +1240,6 @@ def random_element_of_length(self, n):
x = x.apply_simple_reflection_right(antiD[rnd])
return x

# TODO: Groups() should have inverse() call __invert__
# With strong doc stating that this is just a convenience for the user
# and links to ~ / __invert__

# parabolic_subgroup

def _test_simple_projections(self, **options):
Expand Down Expand Up @@ -2260,7 +2257,6 @@ def binary_factorizations(self, predicate=ConstantFunction(True)):
if not predicate(W.one()):
from sage.sets.finite_enumerated_set import FiniteEnumeratedSet
return FiniteEnumeratedSet([])
s = W.simple_reflections()

def succ(u_v):
u, v = u_v
Expand Down Expand Up @@ -2399,7 +2395,7 @@ def bruhat_lower_covers_reflections(self):
wi = self.apply_simple_reflection(i, side='right')
return [(u.apply_simple_reflection(i, side='right'),
r.apply_conjugation_by_simple_reflection(i))
for u,r in wi.bruhat_lower_covers_reflections()
for u, r in wi.bruhat_lower_covers_reflections()
if not u.has_descent(i, side='right')] + [
(wi, self.parent().simple_reflection(i))]

Expand Down Expand Up @@ -3148,7 +3144,7 @@ def kazhdan_lusztig_cell(self, side='left'):
The cell computation uses the optional package ``coxeter3`` in
the background if available to speed up the computation,
even in the different implementations implementations::
even in the different implementations::
sage: # optional - coxeter3, needs sage.combinat sage.groups sage.modules
sage: W = WeylGroup('A3', prefix='s')
Expand Down
2 changes: 2 additions & 0 deletions src/sage/categories/monoids.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,8 @@ def inverse(self):
This is an alias for inversion, which can also be invoked
by ``~x`` for an element ``x``.
Nota Bene: Element classes should implement ``__invert__`` only.
EXAMPLES::
sage: AA(sqrt(~2)).inverse() # needs sage.rings.number_field sage.symbolic
Expand Down

0 comments on commit f6af55c

Please sign in to comment.