Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject nauty version < 2.6 #29462

Closed
kliem opened this issue Apr 4, 2020 · 9 comments
Closed

Reject nauty version < 2.6 #29462

kliem opened this issue Apr 4, 2020 · 9 comments

Comments

@kliem
Copy link
Contributor

kliem commented Apr 4, 2020

We get the following failure on some systems, see e.g. https://github.com/kliem/sage-test-27122/runs/558808988:

File "src/sage/graphs/digraph_generators.py", line 600, in sage.graphs.digraph_generators.DiGraphGenerators.nauty_directg
Failed example:
    dgs[0]
Exception raised:
    Traceback (most recent call last):
      File "/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1123, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.graphs.digraph_generators.DiGraphGenerators.nauty_directg[3]>", line 1, in <module>
        dgs[Integer(0)]
    IndexError: list index out of range
**********************************************************************
File "src/sage/graphs/digraph_generators.py", line 602, in sage.graphs.digraph_generators.DiGraphGenerators.nauty_directg
Failed example:
    dgs[0]._bit_vector()
Exception raised:
    Traceback (most recent call last):
      File "/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1123, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.graphs.digraph_generators.DiGraphGenerators.nauty_directg[4]>", line 1, in <module>
        dgs[Integer(0)]._bit_vector()
    IndexError: list index out of range

The problem is that we use digraph6, a format which is not supported by nauty previous to 2.6 according to

http://users.cecs.anu.edu.au/~bdm/nauty/changes24-26.txt

CC: @mkoeppe @orlitzky @dimpase

Component: packages: standard

Keywords: nauty, digraph6

Author: Michael Orlitzky

Branch/Commit: 642fbc0

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29462

@kliem kliem added this to the sage-9.1 milestone Apr 4, 2020
@orlitzky
Copy link
Contributor

orlitzky commented Apr 4, 2020

Commit: 642fbc0

@orlitzky
Copy link
Contributor

orlitzky commented Apr 4, 2020

New commits:

642fbc0Trac #29462: check for the "converseg" nauty utility.

@orlitzky
Copy link
Contributor

orlitzky commented Apr 4, 2020

Branch: u/mjo/ticket/29462

@orlitzky
Copy link
Contributor

orlitzky commented Apr 4, 2020

Author: Michael Orlitzky

@kliem
Copy link
Contributor Author

kliem commented Apr 4, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Apr 4, 2020

comment:3

I would say it is good to go. Does anyone think this needs testing?

I checked that indeed converseg doesn't show up in version 2.5b9 but it is there in version 2.6.

@kliem
Copy link
Contributor Author

kliem commented Apr 4, 2020

comment:4

I just started a test #29462, #29442, #29440, #29272, #29445.

https://github.com/kliem/sage-test-27122/actions/runs/70559675

I'll put it on positive review, if this works as desired.

@kliem
Copy link
Contributor Author

kliem commented Apr 5, 2020

comment:5

Ok. Works.

E.g. nauty is being rejected on ubuntu-xenial, so that the doctest passes. But it is accepted by ubuntu-bionic.

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from u/mjo/ticket/29462 to 642fbc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants