Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pcre to pcre2 #32231

Closed
orlitzky opened this issue Jul 18, 2021 · 1 comment · Fixed by #35083
Closed

Upgrade pcre to pcre2 #32231

orlitzky opened this issue Jul 18, 2021 · 1 comment · Fixed by #35083
Labels
c: packages: standard t: enhancement
Milestone
sage-10.0

Comments

@orlitzky
Copy link
Contributor

Our "pcre" package exists only as a dependency of R as far as I can tell, and has been replaced by pcre2 (https://www.pcre.org/) both upstream and within R. We should use the newer library instead.

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/32231
@orlitzky orlitzky added this to the sage-9.4 milestone Jul 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe mentioned this issue Feb 12, 2023
Merged
4 tasks
@mkoeppe
Copy link
Member

mkoeppe commented Feb 12, 2023

No longer needed as we have reduced our r package to "dummy".

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2023
@mkoeppe mkoeppe removed this from the sage-9.9 milestone Feb 12, 2023
vbraun pushed a commit that referenced this issue Mar 19, 2023
gh-35083: build/pkgs/pcre: Remove
d29bcae 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
Remove the spkg `pcre`; it was a dependency of our `r` package, which
was reduced to a dummy package recently.
<!-- Why is this change required? What problem does it solve? -->

<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
Closes #32231

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35083
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 19, 2023
@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard t: enhancement
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

build/pkgs/pcre: Remove mkoeppe/sage
2 participants
@orlitzky @mkoeppe