Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/pcre: Remove #35083

Merged
merged 2 commits into from
Mar 19, 2023
Merged

build/pkgs/pcre: Remove #35083

merged 2 commits into from
Mar 19, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Feb 12, 2023

📚 Description

Remove the spkg pcre; it was a dependency of our r package, which was reduced to a dummy package recently.

Closes #32231

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f449b14) 88.62% compared to head (f61e83a) 88.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35083      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398653   398653              
===========================================
- Hits        353308   353258      -50     
- Misses       45345    45395      +50     

see 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe requested a review from dimpase February 12, 2023 14:39
@dimpase
Copy link
Member

dimpase commented Feb 12, 2023

$ git grep pcre
build/pkgs/_prereq/distros/fedora.txt:# Needed for pcre configure, see https://trac.sagemath.org/ticket/29129
...

it actually adds diffutils, which is fine and can be kept, but this comment looks outdated

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 12, 2023

OK, I've removed the comment

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 12, 2023

Thanks, Dima!

@vbraun
Copy link
Member

vbraun commented Mar 13, 2023

Merge conflict

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: f61e83a

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbraun vbraun merged commit d29bcae into sagemath:develop Mar 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pcre to pcre2
4 participants