Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some things from namespace #32647

Closed
fchapoton opened this issue Oct 7, 2021 · 16 comments
Closed

remove some things from namespace #32647

fchapoton opened this issue Oct 7, 2021 · 16 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@fchapoton
Copy link
Contributor

CC: @JohnCremona @roed314 @edgarcosta

Component: refactoring

Author: Frédéric Chapoton

Branch: 32c87b9

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/32647
@fchapoton fchapoton added this to the sage-9.5 milestone Oct 7, 2021
@fchapoton
Copy link
Contributor Author

Commit: bb7b733

@fchapoton
Copy link
Contributor Author

New commits:

bb7b733remove things form namespace (steenrod base and modular forms dimensions)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32647

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2021

Changed commit from bb7b733 to ee21b90

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ee21b90fix some doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

32c87b9fix doctests in doc/

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2021

Changed commit from ee21b90 to 32c87b9

@fchapoton
Copy link
Contributor Author

comment:5

This needs approval from several modular-interested people.

The removed global dimension functions for modular subspaces are still available on demand, and also as methods of the corresponding subspaces of modular forms.

@JohnCremona
Copy link
Member

comment:6

No objection from me.

@roed314
Copy link
Contributor

roed314 commented Oct 10, 2021

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Oct 10, 2021

comment:7

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Oct 19, 2021

Changed branch from u/chapoton/32647 to 32c87b9

@vbraun vbraun closed this as completed in 5c0ceda Oct 19, 2021
@williamstein
Copy link
Contributor

comment:9

Hi,

I ran

dimension_cusp_forms

and was sent to this page with a deprecation warning. Fair enough. I land here with only one obvious big question on my mind: WHERE DID THIS FUNCTION GET MOVED TO?

After a few minutes, I don't know. Before you actually really deprecate this functionality, it would be nice if you provide a link that points to where the new functionality is, e.g., some sort of table? Or at least put a table here with a note in the ticket description that says "See table below".

Obviously, I know that I could look at commits to the git history or use search_src or search our docs to answer this question, but it seems like the answer should be more easily available here too, as I'm thinking about other users besides me.

In any case, using search_src I find

search_src('dimension_cusp_forms')
...

sage: from sage.modular.dims import dimension_cusp_forms

In any case, I do of course agree that "sage.modular.dims" is a good place to put this functionality.

@williamstein
Copy link
Contributor

Changed commit from 32c87b9 to none

@JohnCremona
Copy link
Member

comment:10

To be fair, doing dimension_cusp_forms? does show the docstring with examples which include the relevant import line to use. (I had nothing to do with these changes!)

@slel
Copy link
Member

slel commented May 30, 2022

comment:11

Empty "Authors" or "Reviewers" fields prevent merging tickets.

I wish it was the same for the "Description" field.

mkoeppe added a commit to mkoeppe/sage that referenced this issue May 27, 2024
@mkoeppe
src/sage/algebras/steenrod/all.py: Remove import deprecated in sagema…
d78a132 
…th#32647 (2021)
mkoeppe added a commit to mkoeppe/sage that referenced this issue May 27, 2024
@mkoeppe
src/sage/modular/all.py: Remove imports deprecated in sagemath#32647 …
ee40e77 
…(2021)
vbraun pushed a commit to vbraun/sage that referenced this issue May 29, 2024
sagemathgh-38095: src/sage/algebras/steenrod/all.py: Use lazy_impor…
d634c2d 
…t, remove deprecated global import

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- The change to use `lazy_import` was cherry-picked from sagemath#37900
- The global import was deprecated in sagemath#32647 (2021)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38095
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this issue May 31, 2024
sagemathgh-38095: src/sage/algebras/steenrod/all.py: Use lazy_impor…
da885cf 
…t, remove deprecated global import

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- The change to use `lazy_import` was cherry-picked from sagemath#37900
- The global import was deprecated in sagemath#32647 (2021)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38095
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
6 participants
@roed314 @vbraun @williamstein @slel @JohnCremona @fchapoton