Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix improper names of several special functions for CBF #32869

Closed
dimpase opened this issue Nov 13, 2021 · 9 comments
Closed

fix improper names of several special functions for CBF #32869

dimpase opened this issue Nov 13, 2021 · 9 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-9.5

Comments

@dimpase
Copy link
Member

dimpase commented Nov 13, 2021

CBF, i.e. sage/rings/complex_arb.pyx, names functions such as Ei impoperly, as ei. This in particular makes it impossible to do e.g. CBF(Ei(I)) (one gets infinite recursion error).

The fix is just to rename them. One can first set aliases Ei = ei, etc.,
and deprecate ei, and then, after the deprecation period, do the renaming.

Component: symbolics

Author: Marc Mezzarobba

Branch/Commit: d9ee935

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32869
@dimpase dimpase added this to the sage-9.5 milestone Nov 13, 2021
@mezzarobba
Copy link
Member

comment:1

The names of the symbolic functions are also inconsistent: Ei is Ei, but Si, etc. are actually aliases for sin_integral, etc.

@mezzarobba
Copy link
Member

comment:2

see #32871 for the infinite recursion

New commits:

d9ee935#32869 ComplexBall: rename + add aliases for some special functions

@mezzarobba
Copy link
Member

Commit: d9ee935

@mezzarobba
Copy link
Member

Branch: u/mmezzarobba/CBF_renamespecfuns

@mezzarobba
Copy link
Member

Author: Marc Mezzarobba

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2021

comment:3

lgtm

@mezzarobba
Copy link
Member

comment:4

thank you!

@vbraun
Copy link
Member

vbraun commented Nov 15, 2021

Changed branch from u/mmezzarobba/CBF_renamespecfuns to d9ee935

@vbraun vbraun closed this as completed in 311fd34 Nov 15, 2021
@mezzarobba mezzarobba mentioned this issue Nov 20, 2021
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/complex_arb.pyx: Remove method aliases deprecated in s…
f0a3d1a 
…agemath#32869 (2021)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mezzarobba