Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cygwin CI failing #35048

Closed
roed314 opened this issue Feb 9, 2023 · 1 comment · Fixed by #35052
Closed

Cygwin CI failing #35048

roed314 opened this issue Feb 9, 2023 · 1 comment · Fixed by #35052
Labels
p: major / 3 t: bug
Milestone
sage-10.0

Comments

@roed314
Copy link
Contributor

roed314 commented Feb 9, 2023

On every CI run, I'm getting a failure from a misconfigured cygwin CI workflow:

[Invalid workflow file: .github/workflows/ci-cygwin-standard.yml#L1](https://github.com/roed314/sage/actions/runs/4124660481/workflow)
No steps defined in `steps` and no workflow called in `uses` for the following jobs: cygwin-stage-ii-e

I tried fixing the problem in #35005, but gave up since I don't know how to write github workflows. Some possibly relevant discussion: https://stackoverflow.com/questions/73305126/passing-env-variable-inputs-to-a-reusable-workflow and https://github.com/orgs/community/discussions/26671.

It would be nice to fix this, since I'm getting an email about the failed run every time I push to a PR.
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2023

This was broken by a failed merge in #32841

dimpase added a commit that referenced this issue Feb 15, 2023
@dimpase
Fix Cygwin CI after #32841 (#35052)
525c625 
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
Cygwin workflows were mangled by a bad merge, leading to syntax errors
even whenever the workflow is parsed.

Here we fix this; note that the Cygwin workflow is still not functional
afterward (the first step, installation of Cygwin with choco, fails).
But this will only affect builds of releases and does not happen for PR
CI runs.
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
Closes #35048 

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

Fix Cygwin CI after #32841 sagemath/sage
2 participants
@roed314 @mkoeppe