-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cygwin CI after #32841 #35052
Fix Cygwin CI after #32841 #35052
Conversation
This is certainly an improvement (since the workflow starts now), but it still seems to be failing: https://github.com/sagemath/sage/actions/runs/4137773690. |
You should probably also merge develop. |
Yes, as noted in the PR description. |
No need; nothing else touches these files. |
Ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me: I'm no longer getting syntax errors on the workflow.
Thanks, David! |
Can we have a careful rebase here? I don't want to accidentally destroy |
We can also merge directly into develop... But pick one way. |
What is fix-develop? |
Oh I see, I created the branch in sagemath/sage by accident. Will delete as soon as this PR is merged. |
@dimpase If you choose "Squash" in the merge button dropdown, then the branch history of develop is a bit cleaner than with a classical merge. |
📚 Description
Cygwin workflows were mangled by a bad merge, leading to syntax errors even whenever the workflow is parsed.
Here we fix this; note that the Cygwin workflow is still not functional afterward (the first step, installation of Cygwin with choco, fails). But this will only affect builds of releases and does not happen for PR CI runs.
Closes #35048
📝 Checklist
⌛ Dependencies