Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation error in ncsf ? #38370

Closed
2 tasks done
0-andy-0 opened this issue Jul 15, 2024 · 1 comment · Fixed by #38372
Closed
2 tasks done

Documentation error in ncsf ? #38370

0-andy-0 opened this issue Jul 15, 2024 · 1 comment · Fixed by #38372
Assignees
@fchapoton
Labels
c: combinatorics c: documentation
Milestone
sage-10.5

Comments

@0-andy-0
Copy link
Contributor

Steps To Reproduce

open https://doc.sagemath.org/html/en/reference/combinat/sage/combinat/ncsf_qsym/ncsf.html

Expected Behavior

Maybe should say: Over QQ (or any other Q-algebra), this Hopf algebra Psi is isomorphic to the universal enveloping algebra of its space of primitive elements. The primitives form a countably generated free Lie algebra, so Psi is the tensor algebra on a countably infinity dimension vector space.

Actual Behavior

Says: Over QQ (or any other Q-algebra), this Hopf algebra Psi is isomorphic to the tensor algebra of its space of primitive elements.

Additional Information

No response

Environment

- **OS**: any
- **Sage Version**: 10.3

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@fchapoton fchapoton self-assigned this Jul 15, 2024
@fchapoton
Copy link
Contributor

fchapoton commented Jul 15, 2024 •
edited
Loading

would you like to fix it yourself ?
You can do it here : navigate to the file (Code menu on top of the page) or directly go to

https://github.com/sagemath/sage/blob/develop/src/sage/combinat/ncsf_qsym/ncsf.py

and then click on the pencil to edit the file.

@0-andy-0 0-andy-0 mentioned this issue Jul 15, 2024
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Jul 20, 2024
sagemathgh-38372: Update ncsf.py documentation
d868666 
    
Correction lines 184-189: Psi is not the tensor algebra on the
primitives but on the generators of this free Lie algebra.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Correction lines 184-189: Psi is not the tensor algebra on the
primitives but on the generators of this free Lie algebra.

Fixes sagemath#38370

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38372
Reported by: Andrew Tonks
Reviewer(s): Frédéric Chapoton
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fchapoton fchapoton

Labels
c: combinatorics c: documentation
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging a pull request may close this issue.

Update ncsf.py documentation 0-andy-0/sage
3 participants
@fchapoton @mkoeppe @0-andy-0