Skip to content

Test failure in test-long etc. because of singular #40120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
user202729 opened this issue May 18, 2025 · 4 comments · Fixed by #40157 · May be fixed by #40158
Closed

Test failure in test-long etc. because of singular #40120

user202729 opened this issue May 18, 2025 · 4 comments · Fixed by #40157 · May be fixed by #40158
Labels

Comments

@user202729
Copy link
Contributor

user202729 commented May 18, 2025

Steps To Reproduce

Log on CI https://github.com/sagemath/sage/actions/runs/15081532937/job/42398821050?pr=39973 :

2025-05-17T04:17:53.5248491Z #8 184.2 Trying to install singular
2025-05-17T04:17:54.5097355Z #8 185.2 Trying to install singular-doc
2025-05-17T04:17:55.4740373Z #8 186.2 Trying to install libsingular4-dev

2025-05-17T04:19:24.8961848Z #25 12.32 -----------------------------------------------------------------------------
2025-05-17T04:19:24.8962573Z #25 12.32 Checking whether SageMath should install SPKG singular...
2025-05-17T04:19:24.8963289Z #25 12.32 real_configure: singular has already been installed by SageMath
2025-05-17T04:19:24.8964097Z #25 12.32 -----------------------------------------------------------------------------

2025-05-17T04:19:29.7954224Z #25 17.33 singular:                       installed SPKG version 4.4.0 will be replaced by version 4.4.1
2025-05-17T04:19:29.7954860Z #25 17.34 singular_jupyter:               no; optional, use "./configure --enable-singular_jupyter" to install SPKG version 0.9.7

2025-05-17T05:31:46.2297981Z #31 4321.4 make --no-print-directory singular-SAGE_LOCAL-no-deps
2025-05-17T05:31:46.2298625Z #31 4321.4 [singular-4.4.1] installing. Log file: /sage/logs/pkgs/singular-4.4.1.log
2025-05-17T05:31:46.2299399Z #31 4321.4   [singular-4.4.1] successfully installed (real 16m13.156s user 8m33.854s sys 1m25.894s).

2025-05-17T05:31:46.3195967Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] mkdir -p en/reference/repl
2025-05-17T05:31:46.3196201Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] sage -advanced > en/reference/repl/options.txt
2025-05-17T05:31:46.3196428Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] make doc-inventory--reference-references
2025-05-17T05:31:46.3196704Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] sage --docbuild --no-pdf-links reference/references inventory 
2025-05-17T05:31:46.3196898Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] Error building the documentation.
2025-05-17T05:31:46.3197088Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] Traceback (most recent call last):
2025-05-17T05:31:46.3197337Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "<frozen runpy>", line 198, in _run_module_as_main
2025-05-17T05:31:46.3197557Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "<frozen runpy>", line 88, in _run_code
2025-05-17T05:31:46.3197832Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage_docbuild/__main__.py", line 552, in <module>
2025-05-17T05:31:46.3197999Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     sys.exit(main())
2025-05-17T05:31:46.3198249Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]              ^^^^^^
2025-05-17T05:31:46.3198518Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage_docbuild/__main__.py", line 545, in main
2025-05-17T05:31:46.3198873Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     import sage.all  # TODO: Remove once all modules can be imported independently  # noqa: F401
2025-05-17T05:31:46.3199031Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     ^^^^^^^^^^^^^^^
2025-05-17T05:31:46.3199268Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/all.py", line 96, in <module>
2025-05-17T05:31:46.3199464Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from sage.schemes.all import *
2025-05-17T05:31:46.3199716Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/schemes/all.py", line 25, in <module>
2025-05-17T05:31:46.3199964Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from sage.schemes.hyperelliptic_curves.all import *
2025-05-17T05:31:46.3200299Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/schemes/hyperelliptic_curves/all.py", line 1, in <module>
2025-05-17T05:31:46.3200628Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from sage.schemes.hyperelliptic_curves.constructor import HyperellipticCurve
2025-05-17T05:31:46.3200992Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/schemes/hyperelliptic_curves/constructor.py", line 17, in <module>
2025-05-17T05:31:46.3201275Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from .hyperelliptic_generic import HyperellipticCurve_generic
2025-05-17T05:31:46.3201672Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py", line 36, in <module>
2025-05-17T05:31:46.3201945Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     import sage.schemes.curves.projective_curve as plane_curve
2025-05-17T05:31:46.3202280Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "/sage/src/sage/schemes/curves/projective_curve.py", line 144, in <module>
2025-05-17T05:31:46.3202704Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from sage.libs.singular.function import singular_function, lib as singular_lib, get_printlevel, set_printlevel
2025-05-17T05:31:46.3203057Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]   File "sage/libs/singular/function.pyx", line 98, in init sage.libs.singular.function
2025-05-17T05:31:46.3203369Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install]     from sage.libs.singular.option import opt_ctx
2025-05-17T05:31:46.3203949Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] ImportError: libSingular-4.4.0.so: cannot open shared object file: No such file or directory
2025-05-17T05:31:46.3204245Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] make[6]: *** [Makefile:28: doc-inventory--reference-references] Error 1
2025-05-17T05:31:46.3204500Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] make[5]: *** [Makefile:44: doc-inventory-reference] Error 2
2025-05-17T05:31:46.3204750Z #31 4321.4   [sagemath_doc_html-none]   [spkg-install] make[5]: Target 'doc-html' not remade because of errors.

Also mentioned in #40085 and #39973 (comment)

@user202729
Copy link
Contributor Author

This might be fixed by just bumping singular version. But why do configure spontaneously decide to install 4.4.1 (which is seemingly incompatible with what the code is doing)?

Last times singular was updated

it doesn't seem that pull requests prior to these (e.g. #37790) breaks when singular is updated though. So…

@user202729 user202729 changed the title Test failure in test-long etc. Test failure in test-long etc. because of singular May 18, 2025
@user202729
Copy link
Contributor Author

user202729 commented May 18, 2025

Actually #40033 already updates it to 4.4.1.

This appears to be first introduced in that pull request (https://github.com/sagemath/sage/actions/runs/14761095232/job/41441717381), not sure what went wrong.

@user202729
Copy link
Contributor Author

user202729 commented May 24, 2025

It's claimed in #39973 that it's just a caching issue, but a full build ought to be made for each release, and because #40033 is already merged and https://github.com/sagemath/sage/actions/runs/15095151507/job/42428827874 is built, it ought to work?

Why not?

@user202729
Copy link
Contributor Author

My current best guess for what happens: the docker image needed are no longer pushed. Also explains the massive slowdown seen by test-new earlier (and maybe also test-long now).

If I understood correctly, currently in build.yml the platform is ubuntu-noble-standard, but in ci-linux.yml the operating system is jammy for minimal and ["focal", "jammy"] (the default) for standard, which doesn't include noble.

However noble was initially removed in #39467 .

Looking at the last release before that pull request is merged, ubuntu-noble-standard fails, but ubuntu-noble-minimal succeeds.

What would a reasonable course of action be in this case?

  • fix ubuntu-noble-standard CI Linux and add it back there?
  • switch to ubuntu-noble-minimal?
  • revert to ubuntu-jammy-standard until it is fixed?

@kwankyu @tobiasdiez @dimpase @vbraun help? Currently test-long are not ran at all.

vbraun pushed a commit to vbraun/sage that referenced this issue May 28, 2025
sagemathgh-40157: Add back ubuntu-noble-standard to ci-linux
    
Fixes sagemath#40120 — I believe.

As explained there, the root cause is that `ci-linux.yml` no longer
build from scratch on `ubuntu-noble-standard` to generate the base
docker image for the incremental builds to base on.

In any case this appears to be harmless enough.

From some
[testing](https://github.com/user202729/sage/actions/workflows/ci-
linux.yml) this works _some_ of the time (the debug statements are
harmless)… which is not great, but the **current** `standard` runs
aren't completely reliable either.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40157
Reported by: user202729
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this issue May 29, 2025
sagemathgh-40157: Add back ubuntu-noble-standard to ci-linux
    
Fixes sagemath#40120 — I believe.

As explained there, the root cause is that `ci-linux.yml` no longer
build from scratch on `ubuntu-noble-standard` to generate the base
docker image for the incremental builds to base on.

In any case this appears to be harmless enough.

From some
[testing](https://github.com/user202729/sage/actions/workflows/ci-
linux.yml) this works _some_ of the time (the debug statements are
harmless)… which is not great, but the **current** `standard` runs
aren't completely reliable either.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40157
Reported by: user202729
Reviewer(s): Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant