Add ability to generate graphs based on correlations of sequences #25933 #35009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
suggested changes
Feb 7, 2023
src/sage/graphs/generators/basic.py
Outdated
| adjacency_matrix = Matrix(boolean_adjacency_matrix.astype(int)) | ||
|
|
||
| # call graph constructor | ||
| return Graph(adjacency_matrix, format="adjacency_matrix", name="Correlation Graph") |
There was a problem hiding this comment.
check the linter error (trailing space) in this line
There was a problem hiding this comment.
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35009 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2136 2136
Lines 396141 396151 +10
===========================================
+ Hits 350948 350950 +2
- Misses 45193 45201 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
You can use one of a few select keywords to link a pull request to an issue. For example, editing the description to include "fixes #25933" will instruct GitHub to automatically close #25933 when this pull request gets merged. |
dimpase
changed the title
|
fixes #25933 |
|
that's why tests fail: |
|
and linting fails due to |
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description Fixing the linter workflow <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
dimpase
force-pushed
the
u/gh-Bruno-TT/correlation-graph
branch
from
72f1e46
to
2e17704
Compare
|
Documentation preview for this PR is ready! 🎉 |
dimpase
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25933