Implemented five new operations for dynamical semigroups #35988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homogenize, and dehomogenize; have not tested
and dehomogenize
dehomogenize, and multiply method header
- modified __call__ documentation - removed Counter import - line break changes on a couple other methods
5 tasks
…d private method _remove_duplicates_of
|
Mostly looks good. Here are changes to make: |
MatheMagicianPi
force-pushed
the
dsg_ticket2
branch
from
3e97eac
to
ba7241c
Compare
|
LGTM |
EnderWannabe
approved these changes
Aug 12, 2023
|
Documentation preview for this PR (built with commit fa300ae; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
…roups
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
--> Implemented the following methods for dynamical semigroups:
1. multiply (*) : multiply two dynamical semigroups
2. power (^) : exponentiate a dynamical semigroup
3. nth_iterate : evaluate on a value n times with a dynamical semigroup
4. homogenize : convert affine dynamical semigroups to projective
dynamical semigroups
5. dehomogenize : convert projective dynamical semigroups to affine
dynamical semigroups
<!-- Describe your changes here in detail -->
This is part of issue sagemath#35954
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
--> sagemath#35947 : first implementation of dynamical semigroups
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35988
Reported by: Dang Phan
Reviewer(s): Alexander Galarraga
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 27, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" -->Implemented `orbit` and `specialization` methods for dynamical semigroups. <!-- Describe your changes here in detail --> The orbit method works like the orbit method in dynamical systems, but instead the point is evaluated on using a dynamical semigroup. The specialization method returns a dynamical semigroup defined by the specialization of the generators. This is part of issue sagemath#35954 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> sagemath#35947 sagemath#35988 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36041 Reported by: Dang Phan Reviewer(s): Alexander Galarraga
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of issue #35954
📝 Checklist
⌛ Dependencies
#35947 : first implementation of dynamical semigroups