-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet more more spkgs confs #36332
Yet more more spkgs confs #36332
Conversation
need to add more distros/ stuff |
We could do cython now too. The standard |
ebb218f
to
61162af
Compare
Can you please redo this branch with proper merge commits for its depencies? |
by right, this branch should be based off develop, but it needs #36276, which is only in the "WIP-develop". |
I'd suggest to remove the additions to hatch_nodejs_version because #36129 will remove this package. |
Or let's not lay eggs that are unwanted? |
one cannot realistically scan all the open PRs and check for potential conflicts |
I know, hence my helpful comment |
@orlitzky In the platforms tests for
Any thoughts? |
Looks like cython/cython#5552 |
Unrelated: |
calver is for setting up python package versions via date (CalendarVersion) |
But why create a |
this happends when you put a bunch of .txt files in a wrong place, then move them to the right place, but... |
I tried patching Cython with the patch they provide, still getting this error. PS. Sorry, it's OK - I forgot how to patch Gentoo packages, and the patch got lost... |
I opened a Gentoo bug to backport the patch. Otherwise cython-3.0.3 should fix it, or |
we'd also sort out these endless
warnings, eventually |
9459c5d
to
89a6f9f
Compare
Documentation preview for this PR (built with commit 89a6f9f; changes) is ready! 🎉 |
I don't mind the cython patch but note that it won't help when cython also comes from the system (after this PR). The cython bug you patched is fixed in cython-3.0.3 (#36416), but cython-3.0.3 has a new problem (cython/cython#5748). Hopefully 3.0.4 comes soon. |
see sagemath#35658, in particular sagemath#35658 (comment) and later
89a6f9f
to
27e037f
Compare
a continuation of sagemath#36276 (more system Python packages support via `--enable-system-site-packages`) Also, added a Cython 3.0.2 patch to fix the usage of `--enable-system- site-packages` option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added) URL: sagemath#36332 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36332 (to remove the patch added there) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36332 (to remove the patch added there) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36332 (to remove the patch added there) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36332 (to remove the patch added there) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36332 (to remove the patch added there) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):
a continuation of #36276 (more system Python packages support via
--enable-system-site-packages
)Also, added a Cython 3.0.2 patch to fix the usage of
--enable-system-site-packages
option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added)