Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python3 spkg-configure.m4 to allow system Python 3.12.x #36868

Closed

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Dec 12, 2023

When the necessary package upgrades (see #36181) are completed, we can allow system Python 3.12.x.

@dimpase dimpase requested review from mkoeppe and tornaria December 12, 2023 19:28
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2023

#36407 (comment)

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2023

Rule: First port it, then claim to support it

@dimpase
Copy link
Member Author

dimpase commented Dec 12, 2023

Rule: First port it, then claim to support it

No idea what you mean by "port" here. It's running other people Sage's.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2023

A key package, gmpy2, does not yet support Python 3.12. That's #36351

@mkoeppe mkoeppe changed the title rectify the omitted version bump in #36407 Update python3 spkg-configure.m4 to allow system Python 3.12.x Dec 12, 2023
@dimpase

This comment was marked as abuse.

Copy link

Documentation preview for this PR (built with commit a722a77; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2023

@dimpase This is unwelcome speech.

@dimpase
Copy link
Member Author

dimpase commented Dec 12, 2023

look, you obviously made a mistake by approving a PR with the title "Support Python 3.12" but not actually allowing ./configure to accept it.

Now instead of admitting it 1st of all, you come up with tasks for me to perform before you might allow an appropriate correction. Thus sucks.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2023

Read #36407 (comment)

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 15, 2023

The commit is merged into #36181, closing.

@mkoeppe mkoeppe closed this Dec 15, 2023
@mkoeppe mkoeppe added the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants