Python 3.12.x #36181
Closed
Python 3.12.x #36181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
t/34788/test_ticket__python_3_12
branch
from
1971170
to
6a80e78
Compare
mkoeppe
force-pushed
the
t/34788/test_ticket__python_3_12
branch
from
6a80e78
to
e94b71a
Compare
|
See: sagemath/cypari2#138 and fplll/fpylll#254. |
|
See also WIP: develop...tornaria:sage:py312 With that branch I'm down to ~ 20 test failures (needs to patch fpylll and cypari2 as in the PRs in my comment above) |
|
I'm down to 2 doctest failures (only tested x86_64 for now) and I will do a proper "support python 3.12" PR soon. Meanwhile, I've split a trivial (but long) part of the necessary changes into #36403, which should be trivial to review. |
|
The branch develop...tornaria:sage:py312 seems to be working for me. I'll do some testing overnight, then make a PR tomorrow. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 12, 2023
…suggestion (part of python 3.12 support)
In python 3.12, attribute errors add a suggestion at the end of the
usual error message ("Did you mean ...?").
We add ... at the end of these doctest outputs to fix it.
This PR is split in two commits:
- The bulk of the changes, in the first commit, was obtained
automatically with:
```
git grep -l "AttributeError:" src | xargs sed -ie \
's/^ *\(AttributeError: .*\)\?has no attribute.*$/&.../'
```
- The second commit includes 3 changes not catched by the sed pattern
above.
Since this changes a lot of files and is bound to get old, I'd
appreciate a quick review + merge to avoid trouble (the PR is long but
almost trivial and the review should be easy).
I'll soon make a separate PR (on top of this one) with the rest of the
support python 3.12 changes, which are maybe not so trivial but much
shorter than this one.
Related: sagemath#36181
@mkoeppe 🙏
URL: sagemath#36403
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 19, 2023
This PR adds support for running with python 3.12 from system. This has been tested on the python 3.12 branch of void linux (x86_64, x86_64-musl and i686). The first two commits correspond to sagemath#36403. The rest is split is small pieces and I tried to add reasonable explanations in the commit messages. Reviewing by commit may be easier (ignoring the first two, already reviewed). See also: sagemath#36181 ### ⌛ Dependencies sagemath#36403 URL: sagemath#36407 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
|
Had "fun" with Python 3.12 : python/cpython#112282 |
2 tasks
Are 102 commits necessary to switch to python 3.12? Sagemath works fine with python 3.12 (I shipped 10.2 and now 10.3 using python 3.12). It should only take a small change in |
|
Also, a lot of tests fail. |
What's your point here, if any? This PR, as I am sure if obvious to you, is an integration PR that has merged numerous PRs where the main work happened. |
|
I'm setting to "needs work" for now because of the merge conflict. |
I think you would be surprised if you cared to look at the disputed PRs. |
-1 vote from me here. |
tornaria
added
the
disputed
added 9 commits
March 31, 2024 23:50
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
…stro info
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37833
Reported by: Matthias Köppe
Reviewer(s): Enrique Manuel Artal Bartolo
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 2, 2024
…stro info
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37833
Reported by: Matthias Köppe
Reviewer(s): Enrique Manuel Artal Bartolo
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 10, 2024
…port of Python 3.12.x stable
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
https://docs.python.org/3/whatsnew/changelog.html#python-3-12-4-final
- In part cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37914 (merged here)
- Depends on sagemath#37951 (merged here for sagemath#37026)
- Depends on sagemath#38144 (merged here for testing)
URL: sagemath#37834
Reported by: Matthias Köppe
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
…port of Python 3.12.x stable
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
https://docs.python.org/3/whatsnew/changelog.html#python-3-12-4-final
- In part cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37914 (merged here)
- Depends on sagemath#37951 (merged here for sagemath#37026)
- Depends on sagemath#38144 (merged here for testing)
URL: sagemath#37834
Reported by: Matthias Köppe
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
…port of Python 3.12.x stable
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
https://docs.python.org/3/whatsnew/changelog.html#python-3-12-4-final
- In part cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37914 (merged here)
- Depends on sagemath#37951 (merged here for sagemath#37026)
- Depends on sagemath#38144 (merged here for testing)
URL: sagemath#37834
Reported by: Matthias Köppe
Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 17, 2024
…port of Python 3.12.x stable
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
https://docs.python.org/3/whatsnew/changelog.html#python-3-12-4-final
- In part cherry-picked from sagemath#36181
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37914 (merged here)
- Depends on sagemath#37951 (merged here for sagemath#37026)
- Depends on sagemath#38144 (merged here for testing)
URL: sagemath#37834
Reported by: Matthias Köppe
Reviewer(s):
|
Closing as completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of:
📝 Checklist
⌛ Dependencies
pkgs/sage-conf: Move metadata fromsetup.cfgtopyproject.toml#36561m4/pyproject_toml_metadata.m4: Allow Python 3.12 #36869gmp6.3.0,mpc1.3.1,mpfr4.2.1,mpfrcx0.6.3,gmpy22.2.0a1 #36351gmp6.3.0,mpc1.3.1,mpfr4.2.1,mpfrcx0.6.3 #36775build/pkgs/gmpy2: Fix install-requires after #36351 #36945 (absorbed ingmp6.3.0,mpc1.3.1,mpfr4.2.1,mpfrcx0.6.3,gmpy22.2.0a1 #36351)spkg-configure.m4for Python 3.12 (setuptools instead of distutils) #36983build/pkgs/python3: Update to 3.12.4; declare support of Python 3.12.x stable #37834 (split out from here, to be merged)build/pkgs/{python3,setuptools}: Update fedora distro info #37833 (split out from here)Related / follow-ups:
exceptiongroup,importlib_metadata,importlib_resources,typing_extensions: Require 3.12 features #37402src/environment.yml, minimize conda environments #35593