-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quaternion Algebra Fractional Ideal improvements - equivalence and reduced bases #37100
Merged
Commits on Feb 5, 2024
-
Added QuaternionAlgebra.is_definite(), Quaternion Ideal reduced_basis…
…(), and is_equivalent certificate
Configuration menu - View commit details
-
Copy full SHA for f0f9d5a - Browse repository at this point
Copy the full SHA f0f9d5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 180618e - Browse repository at this point
Copy the full SHA 180618eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc76364 - Browse repository at this point
Copy the full SHA fc76364View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48b3db - Browse repository at this point
Copy the full SHA f48b3dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e234f7a - Browse repository at this point
Copy the full SHA e234f7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9372816 - Browse repository at this point
Copy the full SHA 9372816View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a21d10 - Browse repository at this point
Copy the full SHA 1a21d10View commit details -
Configuration menu - View commit details
-
Copy full SHA for e49fc7e - Browse repository at this point
Copy the full SHA e49fc7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98fdb58 - Browse repository at this point
Copy the full SHA 98fdb58View commit details -
Configuration menu - View commit details
-
Copy full SHA for c17a8e3 - Browse repository at this point
Copy the full SHA c17a8e3View commit details -
- Removed greek letter alpha in docstrings in hopes of this fixing infinite build loops - Updated `.is_definite()` to fit PR sagemath#37173 (up to the reference to Voight's book) - Other small modifications of docstrings, comments and error warnings - Slightly cleaned up code with respect to intermediately defined variables
Configuration menu - View commit details
-
Copy full SHA for a08850e - Browse repository at this point
Copy the full SHA a08850eView commit details -
Implemented first batch of reviewer feedback
- Added deprecation warning for `.is_equivalent` - Removed unnecessary call of `.is_positive_definite()` in `.reduced_basis()` - Reduced `.is_right_equivalent` to `.is_principal` with suitable rescaling - Fixed some error warnings - Modified docstrings, moved examples to non-deprecated methods and randomized test of `.is_principal`
Configuration menu - View commit details
-
Copy full SHA for 7cddcff - Browse repository at this point
Copy the full SHA 7cddcffView commit details -
Configuration menu - View commit details
-
Copy full SHA for d55b29a - Browse repository at this point
Copy the full SHA d55b29aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 039d80e - Browse repository at this point
Copy the full SHA 039d80eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 099b8c9 - Browse repository at this point
Copy the full SHA 099b8c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2524b96 - Browse repository at this point
Copy the full SHA 2524b96View commit details -
Fully integrated sagemath#34976
- Modified definiteness check in `.minimal_element()` and `.isomorphism_to`; also added check of the base field in the latter method - Reduced search for a generator in `.is_principal()` to a call to `.minimal_element()`
Configuration menu - View commit details
-
Copy full SHA for 094a40f - Browse repository at this point
Copy the full SHA 094a40fView commit details -
Configuration menu - View commit details
-
Copy full SHA for abb108b - Browse repository at this point
Copy the full SHA abb108bView commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93f55e2 - Browse repository at this point
Copy the full SHA 93f55e2View commit details -
This is not a fix for the issue - it just adapts the error warning to be more ambiguous, as suggested in sagemath#34976 (comment)
Configuration menu - View commit details
-
Copy full SHA for 1ceae66 - Browse repository at this point
Copy the full SHA 1ceae66View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5617256 - Browse repository at this point
Copy the full SHA 5617256View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf070c9 - Browse repository at this point
Copy the full SHA cf070c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57d933a - Browse repository at this point
Copy the full SHA 57d933aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7778fd - Browse repository at this point
Copy the full SHA b7778fdView commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e5407af - Browse repository at this point
Copy the full SHA e5407afView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a16a934 - Browse repository at this point
Copy the full SHA a16a934View commit details
Commits on Mar 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec581a4 - Browse repository at this point
Copy the full SHA ec581a4View commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d75358 - Browse repository at this point
Copy the full SHA 8d75358View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.