Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion Algebra Fractional Ideal improvements - equivalence and reduced bases #37100

Merged
merged 28 commits into from
Mar 25, 2024

Commits on Feb 5, 2024

  1. Added QuaternionAlgebra.is_definite(), Quaternion Ideal reduced_basis…

    …(), and is_equivalent certificate
    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f0f9d5a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    180618e View commit details
    Browse the repository at this point in the history
  3. reduced_basis must have full rank ideal

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    fc76364 View commit details
    Browse the repository at this point in the history
  4. Removed whitespace

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f48b3db View commit details
    Browse the repository at this point in the history
  5. Added .is_principal

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e234f7a View commit details
    Browse the repository at this point in the history
  6. Fixed codestyle

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9372816 View commit details
    Browse the repository at this point in the history
  7. Fixed codestyle

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1a21d10 View commit details
    Browse the repository at this point in the history
  8. fix

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e49fc7e View commit details
    Browse the repository at this point in the history
  9. fix

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    98fdb58 View commit details
    Browse the repository at this point in the history
  10. Fixed doctest

    jtcc2 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    c17a8e3 View commit details
    Browse the repository at this point in the history
  11. Small modifications

    - Removed greek letter alpha in docstrings in hopes of this fixing infinite build loops
    - Updated `.is_definite()` to fit PR sagemath#37173 (up to the reference to Voight's book)
    - Other small modifications of docstrings, comments and error warnings
    - Slightly cleaned up code with respect to intermediately defined variables
    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a08850e View commit details
    Browse the repository at this point in the history
  12. Implemented first batch of reviewer feedback

    - Added deprecation warning for `.is_equivalent`
    - Removed unnecessary call of `.is_positive_definite()` in `.reduced_basis()`
    - Reduced `.is_right_equivalent` to `.is_principal` with suitable rescaling
    - Fixed some error warnings
    - Modified docstrings, moved examples to non-deprecated methods and randomized test of `.is_principal`
    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7cddcff View commit details
    Browse the repository at this point in the history
  13. Fix lint issues

    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d55b29a View commit details
    Browse the repository at this point in the history
  14. (Attempt to) Fix deprecation failure

    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    039d80e View commit details
    Browse the repository at this point in the history
  15. Replace is_equivalent in BrandtModule

    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    099b8c9 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2524b96 View commit details
    Browse the repository at this point in the history
  17. Fully integrated sagemath#34976

    - Modified definiteness check in `.minimal_element()` and `.isomorphism_to`; also added check of the base field in the latter method
    - Reduced search for a generator in `.is_principal()` to a call to `.minimal_element()`
    S17A05 authored and yyyyx4 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    094a40f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    abb108b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    93f55e2 View commit details
    Browse the repository at this point in the history
  2. Address issue sagemath#37337

    This is not a fix for the issue - it just adapts the error warning to be more ambiguous, as suggested in sagemath#34976 (comment)
    S17A05 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1ceae66 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Fixed isomorphism_to bug

    jtcc2 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5617256 View commit details
    Browse the repository at this point in the history
  2. Fixed lint

    jtcc2 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    cf070c9 View commit details
    Browse the repository at this point in the history
  3. Added tests

    jtcc2 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    57d933a View commit details
    Browse the repository at this point in the history
  4. Added tests

    jtcc2 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b7778fd View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Small correction

    jtcc2 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e5407af View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    a16a934 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Configuration menu
    Copy the full SHA
    ec581a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    8d75358 View commit details
    Browse the repository at this point in the history