Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion Algebra Fractional Ideal improvements - equivalence and reduced bases #37100

Merged
merged 28 commits into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f0f9d5a
Added QuaternionAlgebra.is_definite(), Quaternion Ideal reduced_basis…
jtcc2 Jan 18, 2024
180618e
Improved definiteness check for reduced_basis
jtcc2 Jan 19, 2024
fc76364
reduced_basis must have full rank ideal
jtcc2 Jan 19, 2024
f48b3db
Removed whitespace
jtcc2 Jan 19, 2024
e234f7a
Added .is_principal
jtcc2 Jan 19, 2024
9372816
Fixed codestyle
jtcc2 Jan 19, 2024
1a21d10
Fixed codestyle
jtcc2 Jan 19, 2024
e49fc7e
fix
jtcc2 Jan 19, 2024
98fdb58
fix
jtcc2 Jan 19, 2024
c17a8e3
Fixed doctest
jtcc2 Jan 22, 2024
a08850e
Small modifications
S17A05 Jan 29, 2024
7cddcff
Implemented first batch of reviewer feedback
S17A05 Feb 2, 2024
d55b29a
Fix lint issues
S17A05 Feb 2, 2024
039d80e
(Attempt to) Fix deprecation failure
S17A05 Feb 2, 2024
099b8c9
Replace is_equivalent in BrandtModule
S17A05 Feb 3, 2024
2524b96
Merge branch 'public/isomorphisms_between_quaternion_orders'
yyyyx4 Feb 5, 2024
094a40f
Fully integrated #34976
S17A05 Feb 3, 2024
abb108b
Added check for fractional ideal basis length, removed "local" checks
S17A05 Feb 3, 2024
93f55e2
Merge branch 'develop' into develop
S17A05 Feb 14, 2024
1ceae66
Address issue #37337
S17A05 Feb 14, 2024
5617256
Fixed isomorphism_to bug
jtcc2 Feb 15, 2024
cf070c9
Fixed lint
jtcc2 Feb 15, 2024
57d933a
Added tests
jtcc2 Feb 15, 2024
b7778fd
Added tests
jtcc2 Feb 15, 2024
e5407af
Small correction
jtcc2 Feb 16, 2024
a16a934
Merge branch 'develop' into develop
S17A05 Feb 27, 2024
ec581a4
Merge branch 'develop' into develop
S17A05 Mar 3, 2024
8d75358
Merge branch 'develop' into develop
S17A05 Mar 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading