Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/pyscipopt: Update to 4.4.0, add Cython 3 patch #37392

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 19, 2024

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe force-pushed the pyscipopt-cython3 branch from dc41e85 to c963221 Compare March 2, 2024 05:52
Copy link

github-actions bot commented Mar 2, 2024

Documentation preview for this PR (built with commit c963221; changes) is ready! 🎉

Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2024

@mantepse Can I set this to "positive review"?

Note that I have a follow-up in #37494 with the SCIP 9 upgrade.

Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2024

Thanks!

@mkoeppe mkoeppe modified the milestone: sage-10.3 Mar 15, 2024
@vbraun vbraun merged commit 28965ac into sagemath:develop Mar 31, 2024
17 of 38 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 25, 2024
…plex to 7, papilo to 2.2, pyscipopt to 5, onetbb to 2021.11

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

https://www.scipopt.org/doc-9.0.0/html/RN90.php

- [x] scipopt/SCIP-SDP#12
- [ ] scipopt/soplex#35
- [x] needs pyscipopt update

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37237
- Depends on sagemath#37351
- Depends on sagemath#36970
- Depends on sagemath#37392
    
URL: sagemath#37494
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants