sage --package, sage-get-system-packages: Support PURLs pkg:pypi/DISTRO-NAME, obtain dependencies of wheels from PyPI
#37500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
sage_package_purl
branch
3 times, most recently
from
7f2157c
to
74a3708
Compare
mkoeppe
changed the title
sage --package, sage-get-system-packages: Support PURLs pkg:pypi/DISTRO-NAMEsage --package, sage-get-system-packages: Support PURLs pkg:pypi/DISTRO-NAME, obtain dependencies of wheels from PyPI
culler
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
I am not really qualified to review most of this PR, but I do see some vestigial trace of the code that I provided, and it looks like the overall scheme makes sense. More automation of the process of maintaining the boilerplate in the file-based spkg database seems like a very useful and important contribution.
mkoeppe
force-pushed
the
sage_package_purl
branch
from
e2d9909
to
9fe4529
Compare
mkoeppe
force-pushed
the
sage_package_purl
branch
2 times, most recently
from
9f599b9
to
9008916
Compare
mkoeppe
force-pushed
the
sage_package_purl
branch
from
9008916
to
34dfbad
Compare
|
Documentation preview for this PR (built with commit 06c3f90; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
sage_package_purl
branch
from
34dfbad
to
975d3e3
Compare
kwankyu
reviewed
Apr 24, 2024
|
Otherwise, lgtm. It works well. |
kwankyu
reviewed
Apr 25, 2024
kwankyu
approved these changes
Apr 25, 2024
kwankyu
reviewed
Apr 25, 2024
|
Thanks for the review! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
…rt PURLs `pkg:pypi/DISTRO-NAME`, obtain dependencies of wheels from PyPI
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
We make it possible to refer to Python packages via their PURL (see
[draft PEP 725](https://peps.python.org/pep-0725/#concrete-package-
specification-through-purl)) instead of their SPKG name.
For now a string of the form `pkg:pypi/DISTRO-NAME` is simply a nickname
for the (unique) SPKG that has DISTRO-NAME in their `install-
requires.txt` or `requirements.txt`. The scheme can also be omitted:
`pypi/DISTRO-NAME` also works. And we also map `pkg:generic/PACKAGE-
NAME` to `PACKAGE_NAME`.
Based on code by @culler, `sage --package create --pypi` now also fills
`dependencies` from the PyPI metadata of wheel packages. When some of
the Python dependencies obtained in this way do not have SPKGs yet, they
are also automatically created.
- Preparation for sagemath#31136.
- Split out from sagemath#37250.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37500
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Marc Culler, Matthias Köppe
…RL in sage --package properties
…ls, use pip instead of PYTHON_TOOLCHAIN
…w generates dependencies for wheels
|
Tentative resolve of merge conflict caused by #36982. |
|
Setting back to positive review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make it possible to refer to Python packages via their PURL (see draft PEP 725) instead of their SPKG name.
For now a string of the form
pkg:pypi/DISTRO-NAMEis simply a nickname for the (unique) SPKG that has DISTRO-NAME in theirversion_requirements.txtorrequirements.txt. The scheme can also be omitted:pypi/DISTRO-NAMEalso works. And we also mappkg:generic/PACKAGE-NAMEtoPACKAGE_NAME.Based on code by @culler,
sage --package create --pypinow also fillsdependenciesfrom the PyPI metadata of wheel packages. When some of the Python dependencies obtained in this way do not have SPKGs yet, they are also automatically created.pypi/, rename to match their PyPI name #31136.PipPackageSystem: If EXTERNALLY-MANAGED, issue venv instructions; useFeature(spkg='pkg:pypi/DISTRO-NAME')#37250.📝 Checklist
⌛ Dependencies