-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the category of quasi-modular form rings #37797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small typos in the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming there are no issues with CI.
Documentation preview for this PR (built with commit f230dbb; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw your comment to my question on the forum - Thank you!
I allow myself to set this to positive review. |
Thank you Frédéric for fixing this ! |
fir the category of some rings of quasi-modular forms See https://ask.sagemath.org/question/76909/ ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#37797 Reported by: Frédéric Chapoton Reviewer(s): Sebastian A. Spindler, Seewoo Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
fir the category of some rings of quasi-modular forms
See https://ask.sagemath.org/question/76909/
📝 Checklist