build/pkgs/gambit: Remove #37810
build/pkgs/gambit: Remove #37810
Conversation
|
Documentation preview for this PR (built with commit 7f354a7; changes) is ready! 🎉 |
|
The failures of "CI Linux Incremental" are unrelated and already reported elsewhere. |
| @@ -236,8 +236,7 @@ | |||
| `Gambit <http://gambit.sourceforge.net/>`_ [Gambit]_. At present this is | |||
| the only gambit algorithm available in sage but further development will | |||
There was a problem hiding this comment.
Is "available in sage" accurate? Are you just leaving it as is for the follow-up PR?
|
This leaves many references to gambit, but those will presumably be dealt with in #37809. So the PR feels a little incomplete, but (a) it's easier to leave the many references intact for the follow-up, and (b) it's an improvement over the current situation because gambit just doesn't work for us right now. Is that an accurate assessment? |
|
Yes, that's the idea. I could include a link to the follow-up #37809 in the documentation if you think that would be helpful |
|
I think it's fine without any more documentation, since it is an improvement over what we have now. |
|
Thanks! |
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Removing this broken experimental package, as proposed in 2020. - Closes sagemath#30156 Also removing the module providing outdated "standalone instructions" to use Gambit. Keeping the various references to Gambit tagged with `# optional - gambit`. This will be updated in the follow-up PR" - sagemath#37809 The motivation for opening this PR to remove `gambit` now (2024) is that it removes a remaining use of the function `sdh_setup_bdist_wheel` (the old gambit Python package could not be installed using pip). This a step for the modernization of the build frontend for Python packages in the Sage distribution: - sagemath#35618 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37810 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
Removing this broken experimental package, as proposed in 2020.
Also removing the module providing outdated "standalone instructions" to use Gambit.
Keeping the various references to Gambit tagged with
# optional - gambit. This will be updated in the follow-up PR"pygambit(help wanted!) #37809The motivation for opening this PR to remove
gambitnow (2024) is that it removes a remaining use of the functionsdh_setup_bdist_wheel(the old gambit Python package could not be installed using pip). This a step for the modernization of the build frontend for Python packages in the Sage distribution:pypa/buildinstead ofpip wheel#35618📝 Checklist
⌛ Dependencies