Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetSystem: Minor change to accommodate set input #38056

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented May 22, 2024

This change makes the code cleaner in multiple places.
The PR also includes some docstring edits in set_system.pyx.

⌛ Dependencies

gmou3 added 2 commits May 22, 2024 11:09

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
This change makes the code cleaner in multiple places.
Copy link

github-actions bot commented May 22, 2024

Documentation preview for this PR (built with commit 79143df; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Verified

This commit was signed with the committer’s verified signature.
SageMath version 10.4.beta7, Release Date: 2024-05-25
@gmou3 gmou3 requested a review from tscrim May 25, 2024 11:26
@gmou3 gmou3 changed the title SetSystem: Minor change to accomodate set input SetSystem: Minor change to accommodate set input May 26, 2024
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 27, 2024
    
This change makes the code cleaner in multiple places.
The PR also includes some docstring edits in `set_system.pyx`.

### ⌛ Dependencies

- Depends on sagemath#37930 and sagemath#38027
    
URL: sagemath#38056
Reported by: gmou3
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
    
This change makes the code cleaner in multiple places.
The PR also includes some docstring edits in `set_system.pyx`.

### ⌛ Dependencies

- Depends on sagemath#37930 and sagemath#38027
    
URL: sagemath#38056
Reported by: gmou3
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 7597786 into sagemath:develop Jun 1, 2024
18 checks passed
@gmou3 gmou3 deleted the setsystem_input branch June 1, 2024 22:52
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 1, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 5, 2024
    
Especially for internal functions (starting with `_`).

The PR includes many changes, most of which are algorithmically
inconsequential (simple type declarations and docstring edits).

Careful review is mostly needed for commit `f0fd595`, where some extra
type castings are done within basic `matroid` functions.

### ⌛ Dependencies

- Depends on sagemath#38056.
    
URL: sagemath#38057
Reported by: gmou3
Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 8, 2024
    
Especially for internal functions (starting with `_`).

The PR includes many changes, most of which are algorithmically
inconsequential (simple type declarations and docstring edits).

Careful review is mostly needed for commit `f0fd595`, where some extra
type castings are done within basic `matroid` functions.

### ⌛ Dependencies

- Depends on sagemath#38056.
    
URL: sagemath#38057
Reported by: gmou3
Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants