Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matroids: Declare function input and return types #38057

Merged
merged 13 commits into from
Jun 9, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented May 22, 2024

Especially for internal functions (starting with _).

The PR includes many changes, most of which are algorithmically inconsequential (simple type declarations and docstring edits).

Careful review is mostly needed for commit f0fd595, where some extra type castings are done within basic matroid functions.

⌛ Dependencies

gmou3 added 4 commits May 22, 2024 11:43
Especially for internal functions.
This part (1/2) includes algorithmically neutral or positive changes.
This part contains some algorithmically questionable changes in
`matroid.pyx`. Needs careful review.
Make the thing compile and pass the tests.
Copy link

github-actions bot commented May 22, 2024

Documentation preview for this PR (built with commit c3977dd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 26, 2024

there are test failures

@gmou3 gmou3 force-pushed the type_declarations branch from e905174 to bc11824 Compare May 27, 2024 21:57
@gmou3 gmou3 force-pushed the type_declarations branch from adaf1ee to c7f53a1 Compare May 28, 2024 08:15
@gmou3 gmou3 requested a review from tscrim May 29, 2024 21:26
Deprecate `in/dependent_r_sets`
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM now.
Dropping the r (or k) in independent_sets is a nice solution.

As suggested by mkoeppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 5, 2024
    
Especially for internal functions (starting with `_`).

The PR includes many changes, most of which are algorithmically
inconsequential (simple type declarations and docstring edits).

Careful review is mostly needed for commit `f0fd595`, where some extra
type castings are done within basic `matroid` functions.

### ⌛ Dependencies

- Depends on sagemath#38056.
    
URL: sagemath#38057
Reported by: gmou3
Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
@vbraun vbraun merged commit 3f4c50f into sagemath:develop Jun 9, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 9, 2024
@gmou3 gmou3 deleted the type_declarations branch July 9, 2024 13:10
@gmou3 gmou3 mentioned this pull request Aug 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants