-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of computing columns of matrices over GF(2) #38152
Conversation
Documentation preview for this PR (built with commit 6d3a233; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small style changes, then it should be good. Thanks for the easy but much needed improvement!
Add reviewer suggestions Co-authored-by: grhkm21 <83517584+grhkm21@users.noreply.github.com>
Thanks for the tips -- I was lazy and copy pasted old columns code, so these changes could be applied elsewhere too but that's for another day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good enough. I think the entire file can be refactored later lol
Haha yeah one problem at a time I guess |
In response to issue #38150 I have adjusted the request for columns over dense matrices over GF(2) by replacing the standard call to columns with a transpose followed by a request of rows.
This results in almost a 1000x speed up for large matrices (for the example in the issue).
Old Implementation
New Implementation
Fixes #38150