Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate is_Infinite #38278

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jun 26, 2024

Part of:

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

…k 's/import is_Infinite/import InfinityElement/;/^ +/s/is_(Infinite)[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, InfinityElement)/g'
@mkoeppe mkoeppe self-assigned this Jun 26, 2024
Copy link

Documentation preview for this PR (built with commit 23f0d07; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review June 26, 2024 05:48
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2024

Thanks!

@vbraun vbraun merged commit 8ec83bc into sagemath:develop Jul 24, 2024
23 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the is_Infinite_deprecation branch July 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants