Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate is_Infinite #38278

Merged
merged 3 commits into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sage/geometry/fan_morphism.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
from sage.modules.free_module_morphism import FreeModuleMorphism
from sage.rings.infinity import Infinity
from sage.rings.integer_ring import ZZ
from sage.rings.infinity import is_Infinite
from sage.rings.infinity import InfinityElement
from functools import reduce


Expand Down Expand Up @@ -1458,7 +1458,7 @@ def is_surjective(self):
sage: phi.is_surjective()
False
"""
if is_Infinite(self.index()):
if isinstance(self.index(), InfinityElement):
return False # Not surjective between vector spaces.
for dcones in self.codomain_fan().cones():
for sigma_p in dcones:
Expand Down
4 changes: 2 additions & 2 deletions src/sage/modular/arithgroup/arithgroup_element.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ cdef class ArithmeticSubgroupElement(MultiplicativeGroupElement):
sage: G([1, 4, 0, 1]).acton(infinity)
+Infinity
"""
from sage.rings.infinity import is_Infinite, infinity
if is_Infinite(z):
from sage.rings.infinity import InfinityElement, infinity
if isinstance(z, InfinityElement):
if self.c() != 0:
return self.a() / self.c()
else:
Expand Down
7 changes: 7 additions & 0 deletions src/sage/rings/infinity.py
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,10 @@ def is_Infinite(x) -> bool:
EXAMPLES::

sage: sage.rings.infinity.is_Infinite(oo)
doctest:warning...
DeprecationWarning: The function is_Infinite is deprecated;
use 'isinstance(..., InfinityElement)' instead.
See https://github.com/sagemath/sage/issues/38022 for details.
True
sage: sage.rings.infinity.is_Infinite(-oo)
True
Expand All @@ -988,6 +992,9 @@ def is_Infinite(x) -> bool:
sage: sage.rings.infinity.is_Infinite(ZZ)
False
"""
from sage.misc.superseded import deprecation
deprecation(38022, "The function is_Infinite is deprecated; use 'isinstance(..., InfinityElement)' instead.")

return isinstance(x, InfinityElement)


Expand Down
6 changes: 3 additions & 3 deletions src/sage/rings/multi_power_series_ring_element.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
from sage.structure.richcmp import richcmp

from sage.rings.finite_rings.integer_mod_ring import Zmod
from sage.rings.infinity import infinity, is_Infinite
from sage.rings.infinity import infinity, InfinityElement
from sage.rings.integer import Integer
from sage.rings.polynomial.polynomial_ring import is_PolynomialRing
from sage.rings.power_series_ring import is_PowerSeriesRing
Expand Down Expand Up @@ -1956,7 +1956,7 @@ def exp(self, prec=infinity):
assert (val >= 1)

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
n_inv_factorial = R.base_ring().one()
x_pow_n = Rbg.one()
Expand Down Expand Up @@ -2053,7 +2053,7 @@ def log(self, prec=infinity):
assert (val >= 1)

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
x_pow_n = Rbg.one()
log_x = Rbg.zero().add_bigoh(prec)
Expand Down
10 changes: 5 additions & 5 deletions src/sage/rings/power_series_ring_element.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ With power series the behavior is the same.
# ****************************************************************************

from cpython.object cimport Py_EQ, Py_NE
from sage.rings.infinity import infinity, is_Infinite
from sage.rings.infinity import infinity, InfinityElement

from sage.rings.rational_field import QQ

Expand Down Expand Up @@ -1901,7 +1901,7 @@ cdef class PowerSeries(AlgebraElement):
assert(val >= 1)

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
n_inv_factorial = R.base_ring().one()
x_pow_n = R.one()
Expand Down Expand Up @@ -1987,7 +1987,7 @@ cdef class PowerSeries(AlgebraElement):
x = self

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
n_inv_factorial = R.base_ring().one()
x_pow_n = x
Expand Down Expand Up @@ -2140,7 +2140,7 @@ cdef class PowerSeries(AlgebraElement):
x = self

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
n_inv_factorial = R.base_ring().one()
x_pow_n = x
Expand Down Expand Up @@ -2228,7 +2228,7 @@ cdef class PowerSeries(AlgebraElement):
assert(val >= 1)

prec = min(prec, self.prec())
if is_Infinite(prec):
if isinstance(prec, InfinityElement):
prec = R.default_prec()
n_inv_factorial = R.base_ring().one()
x_pow_n = R.one()
Expand Down
Loading